Review main Merged

71985[BUGFIX] Drop a strange internal DataHandler method

Christian Kuhn CR +2 V +2 Easy +2 −27 updated 10/26/21, 20:31

Commit message

That's a seldom gem.

Method convNumEntityToByteValue() in DataHandler
is *seriously* strange. It exists since very early
TYPO3 claiming to fix a "very rare" MSIE bug. It
*tries* to convert the "{" of a string like
"foo{bar" to an ascii char ("{") and does
this with a weird logic that includes a microtime().

Testing this thing locally reveals the method
returns different results per execution!

The patch drops that @internal method and it's
caller.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1520

  1. Christian Kuhn uploaded patch set 1 10/26/21, 18:19

  2. Stefan Bürk voted on patch set 1 V +1 CR +1 10/26/21, 18:20

  3. Jochen Roth voted on patch set 1 V +1 CR +1 10/26/21, 18:21

  4. Christian Kuhn voted on patch set 1 CR -1 10/26/21, 18:22

  5. Christian Kuhn uploaded patch set 2 10/26/21, 18:26

  6. Christian Kuhn voted on patch set 2 CR -1 10/26/21, 18:30

  7. core-ci voted on patch set 1 V +1 10/26/21, 18:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18581

  8. core-ci voted on patch set 2 V +1 10/26/21, 18:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18582

  9. Christian Kuhn uploaded patch set 3 10/26/21, 18:51

  10. Christian Kuhn updated the commit message in patch set 4 10/26/21, 18:53

  11. Stefan Bürk voted on patch set 4 V +1 CR +1 10/26/21, 19:03

  12. core-ci voted on patch set 3 V -1 10/26/21, 19:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18583

  13. core-ci voted on patch set 4 V -1 10/26/21, 19:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18584

  14. Christian Kuhn uploaded patch set 5 10/26/21, 19:40

  15. Stefan Bürk voted on patch set 5 V +1 CR +1 10/26/21, 19:43

  16. core-ci voted on patch set 5 V +1 10/26/21, 19:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18587

  17. Jochen Roth voted on patch set 5 V +1 CR +1 10/26/21, 20:09

  18. Benni Mack voted on patch set 5 V +2 CR +2 10/26/21, 20:31

  19. Benni Mack commented on patch set 5 10/26/21, 20:31

    FYI: This code was related to "internal_type=file", which was removed in TYPO3 v10.
  20. Benni Mack merged patch set 6 10/26/21, 20:31