Review main Merged

71986[BUGFIX] Sanitize unserialize() in ProcessedFile

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 10/26/21, 21:18

Commit message

Table sys_file_processedfile field configuration is a
blob. It usually contains a serialized array with
processing information, but can be null due to the
nature of blob. unserialize(null) emits an E_DEPRECATED
error with PHP 8.1. ProcessedFileTest stumbles here,
we however don't fix that in the test, but in the code
to deal with the fact that this table field might be
null in DB for whatever reasons.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 10/26/21, 19:37

  2. Stefan Bürk voted on patch set 1 V +1 CR +1 10/26/21, 19:43

  3. core-ci voted on patch set 1 V +1 10/26/21, 19:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18585

  4. Jochen Roth voted on patch set 1 V +1 CR +1 10/26/21, 20:24

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 10/26/21, 21:18

  6. Christian Kuhn merged patch set 2 10/26/21, 21:18