Review main Merged

71987[BUGFIX] Explicit string cast for string expecting functions

Christian Kuhn CR +2 V +2 Easy +10 −9 updated 10/26/21, 21:30

Commit message

PHP 8.1 in non strict_types context emits E_DEPRECATED
with various functions that expect strings but are
called giving null instead.

The patch sanitizes a series of places to explicitely
string cast arguments.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Simon Gilli +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 69

  1. Christian Kuhn uploaded patch set 1 10/26/21, 20:04

  2. Stefan Bürk voted on patch set 1 V +1 CR +1 10/26/21, 20:23

  3. core-ci voted on patch set 1 V -1 10/26/21, 20:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18588

  4. core-ci commented on patch set 1 10/26/21, 20:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18588

  5. core-ci voted on patch set 1 V +1 10/26/21, 20:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18588

  6. Wouter Wolters voted on patch set 1 CR +1 10/26/21, 21:25

  7. Simon Gilli voted on patch set 1 V +1 CR +1 10/26/21, 21:25

  8. Christian Kuhn voted on patch set 1 V +2 CR +2 10/26/21, 21:30

  9. Christian Kuhn merged patch set 2 10/26/21, 21:30