Review main Merged

71988[TASK] Add acceptance test for recycler module

Jochen Roth CR +2 V +2 Normal +159 −2 updated 11/03/21, 13:53

Commit message

An acceptance test for recycler has been added to
ensure the modules works as expected.

This acceptance test covers the following scenarios:

* Recover records flagged as deleted
* Nuke records from database

As a side effect, fallback values for DatabaseRecordList
and RecordList have been added to make the tests work.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1422

  1. Jochen Roth uploaded patch set 1 10/26/21, 20:07

  2. core-ci voted on patch set 1 V -1 10/26/21, 20:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18589

  3. Jochen Roth uploaded patch set 2 10/27/21, 10:58

  4. core-ci voted on patch set 2 V +1 10/27/21, 11:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18616

  5. Jochen Roth uploaded patch set 3 10/27/21, 11:56

  6. core-ci voted on patch set 3 V -1 10/27/21, 12:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18617

  7. Jochen Roth uploaded patch set 4 10/27/21, 12:49

  8. core-ci voted on patch set 4 V +1 10/27/21, 13:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18618

  9. Guido Schmechel voted on patch set 4 CR +1 10/30/21, 09:19

  10. Andreas Kienast commented on patch set 4 CR +1 11/01/21, 10:49

    This sentence reads incomplete.
  11. Jochen Roth uploaded patch set 5 11/02/21, 08:33

  12. Jochen Roth updated the commit message in patch set 6 11/02/21, 08:34

  13. Jochen Roth updated the commit message in patch set 7 11/02/21, 08:35

  14. Jochen Roth commented on patch set 7 11/02/21, 08:36

    Reply

    Done
  15. core-ci voted on patch set 5 V -1 11/02/21, 08:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18741

  16. core-ci voted on patch set 6 V -1 11/02/21, 08:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18742

  17. core-ci voted on patch set 7 V -1 11/02/21, 08:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18743

  18. Jochen Roth rebased onto patch set 8 11/03/21, 12:03

  19. core-ci voted on patch set 8 V +1 11/03/21, 12:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18780

  20. Anja Leichsenring voted on patch set 8 V +1 CR +1 11/03/21, 13:52

  21. Andreas Kienast voted on patch set 8 V +2 CR +2 11/03/21, 13:53

  22. Andreas Kienast merged patch set 9 11/03/21, 13:53