Review main Merged

71989[BUGFIX] Avoid broken mock return in ActionControllerTest

Stefan Bürk CR +2 V +2 Easy +2 −2 updated 10/26/21, 21:30

Commit message

ActionControllerTest mocks a view to test things. The subject
calls renderSection() on that mock. renderSection() must return
strings and always does that in non-testing context. The mock
is fine tuned to return strings, too.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Wouter Wolters +1
    • Simon Gilli +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Wouter Wolters +1
    • Simon Gilli +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 78

  1. Stefan Bürk uploaded patch set 1 10/26/21, 20:10

  2. Christian Kuhn voted on patch set 1 V +1 CR +1 10/26/21, 20:11

  3. core-ci voted on patch set 1 V +1 10/26/21, 20:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18590

  4. Jochen Roth voted on patch set 1 V +1 CR +1 10/26/21, 21:21

  5. Wouter Wolters voted on patch set 1 V +1 CR +1 10/26/21, 21:22

  6. Simon Gilli voted on patch set 1 V +1 CR +1 10/26/21, 21:29

  7. Christian Kuhn voted on patch set 1 V +2 CR +2 10/26/21, 21:30

  8. Christian Kuhn merged patch set 2 10/26/21, 21:30