Review main Merged

71991[BUGFIX] Harden types in ImageContentObject linkWrap()

Christian Kuhn CR +2 V +2 Easy +2 −10 updated 10/27/21, 09:57

Commit message

Protected method linkWrap() should only be called
with string arguments - they are for instance fed
to explode(). Instead of casting accordingly, we
harden the method signature and add a return type
along the way.

A unit test low-level tests linkWrap(), one data
set does non make sense with that change anymore,
and is removed.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Jochen Roth +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Jochen Roth +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Christian Kuhn uploaded patch set 1 10/26/21, 22:11

  2. Stefan Bürk voted on patch set 1 V +1 CR +1 10/26/21, 22:16

  3. core-ci voted on patch set 1 V +1 10/26/21, 22:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18603

  4. Jochen Roth voted on patch set 1 V +1 CR +1 10/26/21, 22:27

  5. Georg Ringer voted on patch set 1 V +2 CR +2 10/27/21, 09:57

  6. Georg Ringer merged patch set 2 10/27/21, 09:57