Review main Merged

71992[BUGFIX] Prepare doctrine facades towards PHP 8.1

Christian Kuhn CR +2 V +2 Easy +19 −15 updated 10/27/21, 18:59

Commit message

\PDO::quote() is picky about the type argument
in PHP 8.1. doctrine/dbal partially works around
that and will improve with upcoming releases in
this area. Our facade classes should still sanitize
null arguments in a backwards compatible way.

The patch adjusts signatures of quote() and literal()
and explitictly avoids handing null to doctrine and
lower level PDO methods.

A unit test prophecy dealing with defaults needs
to be adjusted along the way.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 56

  1. Christian Kuhn uploaded patch set 1 10/26/21, 23:38

  2. core-ci voted on patch set 1 V +1 10/26/21, 23:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18605

  3. Nikita Hovratov voted on patch set 1 V +1 CR +1 10/27/21, 06:43

  4. Stefan Bürk voted on patch set 1 V +1 CR +1 10/27/21, 08:54

  5. Benni Mack voted on patch set 1 V +2 CR +2 10/27/21, 18:59

  6. Benni Mack merged patch set 2 10/27/21, 18:59