71994[TASK] Refactor localization tests
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Andreas Kienast +1
- Helmut Hummel +1
-
Verified V +2 Done
- Benni Mack +2
- Helmut Hummel +1
- core-ci +1 CI
Issues 1
Files 12
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_localization/Resources/Private/Language/de.locallang_override.xlfnew+20 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_localization/Resources/Private/Language/fr.locallang.xlfnew+20 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_localization/Resources/Private/Language/fr.locallang_common_override.xlfnew+20 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_localization/Resources/Private/Language/fr.locallang_override.xlfrenamed+1 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_localization/Resources/Private/Language/locallang.xlfnew+17 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_localization/Resources/Private/Language/locallang_common_override.xlfnew+17 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_localization/Resources/Private/Language/locallang_override.xlfrenamed+1 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_localization/ext_emconf.phpnew+22 −0
- typo3/sysext/core/Tests/Functional/Localization/LanguageServiceTest.php+146 −8
- typo3/sysext/core/Tests/Unit/Localization/Fixtures/locallang.xlfnew+11 −0
- typo3/sysext/core/Tests/Unit/Localization/Parser/XliffParserTest.php+17 −116
- typo3/sysext/core/Tests/Unit/Localization/LocalizationFactoryTest.php+35 −19
Review log 2137
Show 712 earlier messages
-
Simon Gilli uploaded patch set 1 10/27/21, 09:06
-
core-ci voted on patch set 1 V +1 10/27/21, 09:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18611
-
Simon Gilli uploaded patch set 2 10/27/21, 20:51
-
core-ci voted on patch set 2 V +1 10/27/21, 21:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18634
-
Simon Gilli commented on patch set 2 10/27/21, 21:18
This change is ready for review. -
Helmut Hummel uploaded patch set 3 10/30/21, 12:16
-
core-ci voted on patch set 3 V +1 10/30/21, 12:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18667
-
Simon Gilli uploaded patch set 4 10/30/21, 15:11
-
core-ci voted on patch set 4 V -1 10/30/21, 15:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18672
-
Simon Gilli uploaded patch set 5 10/30/21, 16:04
-
core-ci voted on patch set 5 V -1 10/30/21, 16:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18674
-
Simon Gilli uploaded patch set 6 10/30/21, 16:11
-
core-ci voted on patch set 6 V -1 10/30/21, 16:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18675
-
Simon Gilli uploaded patch set 7 10/30/21, 17:15
-
Simon Gilli uploaded patch set 8 10/30/21, 17:18
-
Simon Gilli uploaded patch set 9 10/30/21, 17:19
-
Simon Gilli uploaded patch set 10 10/30/21, 17:21
-
core-ci voted on patch set 7 V -1 10/30/21, 17:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18676
-
core-ci voted on patch set 8 V -1 10/30/21, 17:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18677
-
core-ci voted on patch set 10 V -1 10/30/21, 17:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18679
-
core-ci voted on patch set 9 V -1 10/30/21, 17:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18678
-
Simon Gilli uploaded patch set 11 10/30/21, 18:32
-
core-ci voted on patch set 11 V -1 10/30/21, 19:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18686
-
Simon Gilli uploaded patch set 12 10/30/21, 19:23
-
Simon Gilli uploaded patch set 13 10/30/21, 19:26
-
core-ci voted on patch set 12 V +1 10/30/21, 19:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18687
-
core-ci voted on patch set 13 V +1 10/30/21, 19:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18688
-
Simon Gilli updated the commit message in patch set 14 10/30/21, 20:06
-
core-ci voted on patch set 14 V +1 10/30/21, 20:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18689
-
Simon Gilli uploaded patch set 15 10/30/21, 22:34
-
core-ci voted on patch set 15 V +1 10/30/21, 22:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18690
-
Simon Gilli uploaded patch set 16 10/31/21, 00:10
-
core-ci voted on patch set 16 V +1 10/31/21, 00:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18692
-
Andreas Kienast voted on patch set 16 CR +1 11/01/21, 10:36
-
Helmut Hummel commented on patch set 16 V +1 CR +1 11/01/21, 11:36
Very nice, thanks! -
Benni Mack voted on patch set 16 V +2 CR +2 11/01/21, 12:05
-
Benni Mack merged patch set 17 11/01/21, 12:05