Review main Merged

71994[TASK] Refactor localization tests

Simon Gilli CR +2 V +2 Hard +327 −145 updated 11/01/21, 12:05

Commit message

The XliffParserTest are refactored using a DataProvider which also
eliminates duplicate test code.

The override tests are moved to the LanguageServiceTest and extended by
more test scenarios.

The LocalizationFactoryTest is refactored using prohecies instead of
mocking the classes and a new test is added.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • Helmut Hummel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Helmut Hummel +1
    • core-ci +1 CI

Issues 1

Files 12

Review log 2137

Show 712 earlier messages
  1. Simon Gilli uploaded patch set 1 10/27/21, 09:06

  2. core-ci voted on patch set 1 V +1 10/27/21, 09:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18611

  3. Simon Gilli uploaded patch set 2 10/27/21, 20:51

  4. core-ci voted on patch set 2 V +1 10/27/21, 21:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18634

  5. Simon Gilli commented on patch set 2 10/27/21, 21:18

    This change is ready for review.
  6. Helmut Hummel uploaded patch set 3 10/30/21, 12:16

  7. core-ci voted on patch set 3 V +1 10/30/21, 12:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18667

  8. Simon Gilli uploaded patch set 4 10/30/21, 15:11

  9. core-ci voted on patch set 4 V -1 10/30/21, 15:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18672

  10. Simon Gilli uploaded patch set 5 10/30/21, 16:04

  11. core-ci voted on patch set 5 V -1 10/30/21, 16:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18674

  12. Simon Gilli uploaded patch set 6 10/30/21, 16:11

  1. core-ci voted on patch set 6 V -1 10/30/21, 16:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18675

  2. Simon Gilli uploaded patch set 7 10/30/21, 17:15

  3. Simon Gilli uploaded patch set 8 10/30/21, 17:18

  4. Simon Gilli uploaded patch set 9 10/30/21, 17:19

  5. Simon Gilli uploaded patch set 10 10/30/21, 17:21

  6. core-ci voted on patch set 7 V -1 10/30/21, 17:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18676

  7. core-ci voted on patch set 8 V -1 10/30/21, 17:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18677

  8. core-ci voted on patch set 10 V -1 10/30/21, 17:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18679

  9. core-ci voted on patch set 9 V -1 10/30/21, 17:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18678

  10. Simon Gilli uploaded patch set 11 10/30/21, 18:32

  11. core-ci voted on patch set 11 V -1 10/30/21, 19:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18686

  12. Simon Gilli uploaded patch set 12 10/30/21, 19:23

  13. Simon Gilli uploaded patch set 13 10/30/21, 19:26

  14. core-ci voted on patch set 12 V +1 10/30/21, 19:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18687

  15. core-ci voted on patch set 13 V +1 10/30/21, 19:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18688

  16. Simon Gilli updated the commit message in patch set 14 10/30/21, 20:06

  17. core-ci voted on patch set 14 V +1 10/30/21, 20:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18689

  18. Simon Gilli uploaded patch set 15 10/30/21, 22:34

  19. core-ci voted on patch set 15 V +1 10/30/21, 22:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18690

  20. Simon Gilli uploaded patch set 16 10/31/21, 00:10

  21. core-ci voted on patch set 16 V +1 10/31/21, 00:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18692

  22. Andreas Kienast voted on patch set 16 CR +1 11/01/21, 10:36

  23. Helmut Hummel commented on patch set 16 V +1 CR +1 11/01/21, 11:36

    Very nice, thanks!
  24. Benni Mack voted on patch set 16 V +2 CR +2 11/01/21, 12:05

  25. Benni Mack merged patch set 17 11/01/21, 12:05