71995[BUGFIX] Don't throw exceptions for private paths
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Simon Gilli +1
- Nikita Hovratov +1
- Benni Mack +1
-
Verified V +2 Done
- Andreas Kienast +2
- Simon Gilli +1
- Nikita Hovratov +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/core/Classes/Utility/PathUtility.php+12 −3
- typo3/sysext/core/Documentation/Changelog/11.5.x/Deprecation-95800-GeneratingPublicURLForPrivateAssetFiles.rstnew+34 −0
- typo3/sysext/core/Tests/Unit/Utility/PathUtilityPublicPathsTest.phpnew+158 −0
- typo3/sysext/core/Tests/UnitDeprecated/Utility/PathUtilityPublicPathsTest.phpnew+112 −0
- typo3/sysext/frontend/Classes/Resource/FilePathSanitizer.php+1 −1
- typo3/sysext/frontend/Tests/Unit/Resource/FilePathSanitizerTest.php+0 −4
- typo3/sysext/frontend/Tests/UnitDeprecated/Resource/FilePathSanitizerTest.phpnew+36 −0
Review log 1724
-
Helmut Hummel uploaded patch set 1 10/27/21, 09:30
-
core-ci voted on patch set 1 V -1 10/27/21, 09:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18614
-
Helmut Hummel uploaded patch set 2 10/27/21, 10:41
-
core-ci voted on patch set 2 V -1 10/27/21, 11:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18615
-
Benni Mack updated the commit message in patch set 3 10/27/21, 13:02
-
core-ci voted on patch set 3 V -1 10/27/21, 13:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18619
-
Helmut Hummel uploaded patch set 4 10/27/21, 14:07
-
core-ci voted on patch set 4 V +1 10/27/21, 14:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18621
-
Benni Mack commented on patch set 4 10/27/21, 20:20
works for me! -
Benni Mack updated the commit message in patch set 5 10/27/21, 20:20
-
Benni Mack voted on patch set 5 V +1 CR +1 10/27/21, 20:20
-
core-ci voted on patch set 5 V +1 10/27/21, 20:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18632
-
Helmut Hummel uploaded patch set 6 10/28/21, 08:45
-
Simon Gilli commented on patch set 6 V -1 CR +1 10/28/21, 08:56
Looks good, testing now... -
core-ci voted on patch set 6 V +1 10/28/21, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18641
-
Simon Gilli commented on patch set 6 V +1 10/28/21, 10:22
That patch works fine. User of the Boostrap Package using the StaticFilesProcessor will currently never see the deprecation. This is also the case for a default installtion for the logo. But that's an issue of the Boostrap Package because of the abuse of the storage 0 and has to be solved there properly. -
Benni Mack voted on patch set 6 V +1 CR +1 10/28/21, 12:08
-
Benni Mack commented on patch set 7 10/28/21, 13:31
Published edit on patch set 6. -
core-ci voted on patch set 7 V +1 10/28/21, 13:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18646
-
Simon Gilli voted on patch set 7 V +1 CR +1 10/28/21, 19:31
-
Nikita Hovratov voted on patch set 7 V +1 CR +1 10/29/21, 13:25
-
Benni Mack voted on patch set 7 V +1 CR +1 10/29/21, 18:38
-
Andreas Kienast voted on patch set 7 V +2 CR +2 11/01/21, 10:56
-
Andreas Kienast merged patch set 8 11/01/21, 10:56