71997[BUGFIX] Use forced scheme only if set and not empty
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Guido Schmechel +1
- Aimeos +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Christian Kuhn +2
- Nikita Hovratov +1
- core-ci +1 CI
Issues 2
Files 1
Review log 1214
-
Georg Ringer uploaded patch set 1 10/27/21, 16:15
-
Georg Ringer commented on patch set 1 10/27/21, 16:17
This change is ready for review. -
core-ci voted on patch set 1 V +1 10/27/21, 16:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18624
-
Aimeos voted on patch set 1 CR +1 10/27/21, 17:10
-
Nikita Hovratov uploaded patch set 2 10/27/21, 17:40
-
Nikita Hovratov voted on patch set 2 V +1 CR +1 10/27/21, 17:41
-
core-ci voted on patch set 2 V +1 10/27/21, 18:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18627
-
Guido Schmechel voted on patch set 2 CR +1 10/27/21, 20:17
-
Aimeos voted on patch set 2 CR +1 10/28/21, 06:47
-
Oliver Klee commented on patch set 2 10/28/21, 07:54
Can we cover this with a regresseion test? -
Nikita Hovratov commented on patch set 2 10/28/21, 16:52
Reply
I would love to, but right now there are no active tests for PageLinkBuilder. The only ones are deactivated, because of side effects. I would just go without a test and add it later, when these issues are resolved. -
Oliver Klee voted on patch set 2 CR +1 11/06/21, 15:12
-
Christian Kuhn voted on patch set 2 V +2 CR +2 11/08/21, 11:35
-
Christian Kuhn merged patch set 3 11/08/21, 11:35