Review main Merged

71998[BUGFIX] Use CodeMirror auto sizing feature correctly

Nikita Hovratov CR +2 V +2 Easy +7 −6 updated 11/03/21, 19:45

Commit message

To use CodeMirror's auto sizing feature, we need
to set the style attribute of the wrapper element
to "auto", instead of providing the "height" option.

In a previous patch a related issue was fixed by
setting the height to the remaining space of the
frame. This led to another issue, which occurs,
when there is already little space left.

Both is fixed by using the auto sizing option
correctly and even gives us the benefit of
automatic resizing, when changing the editor's
content.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 912

  1. Nikita Hovratov uploaded patch set 1 10/27/21, 17:08

  2. core-ci voted on patch set 1 V +1 10/27/21, 17:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18625

  3. Anja Leichsenring voted on patch set 1 V +1 CR +1 11/03/21, 17:37

  4. Anja Leichsenring updated the commit message in patch set 2 11/03/21, 19:10

  5. Oli Bartsch updated the commit message in patch set 3 11/03/21, 19:17

  6. Georg Ringer voted on patch set 2 V +1 CR +1 11/03/21, 19:17

  7. Christian Kuhn voted on patch set 3 V +1 CR +1 11/03/21, 19:18

  8. Oli Bartsch voted on patch set 3 V +1 CR +1 11/03/21, 19:18

  9. core-ci voted on patch set 2 V +1 11/03/21, 19:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18814

  10. core-ci voted on patch set 3 V +1 11/03/21, 19:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18816

  11. Anja Leichsenring voted on patch set 3 V +2 CR +2 11/03/21, 19:45

  12. Anja Leichsenring merged patch set 4 11/03/21, 19:45