72001[TASK] Streamline delete message for page and list view
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
- Jochen Roth +1
-
Verified V +2 Done
- Andreas Kienast +2
- Oli Bartsch +1
- Jochen Roth +1
- core-ci +1 CI
Issues 2
Files 21
- Build/Sources/TypeScript/backend/form-engine/container/inline-control-container.ts+1 −1
- Build/Sources/TypeScript/backend/form-engine/container/site-language-container.ts+1 −1
- Build/Sources/TypeScript/backend/form-engine.ts2+3 −3
- typo3/sysext/backend/Classes/ContextMenu/ItemProviders/RecordProvider.php+9 −5
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php4+6 −0
- typo3/sysext/backend/Classes/Form/Container/InlineRecordContainer.php8+10 −1
- typo3/sysext/backend/Classes/Form/FormResultCompiler.php+10 −6
- typo3/sysext/backend/Classes/View/BackendLayout/Grid/GridColumnItem.php8+34 −0
- typo3/sysext/backend/Classes/View/PageLayoutView.php2+8 −3
- typo3/sysext/backend/Resources/Private/Language/locallang_alt_doc.xlf4+2 −2
- typo3/sysext/backend/Resources/Private/Language/locallang_layout.xlf2+1 −1
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/RecordDefault/Header.html+2 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/container/inline-control-container.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/container/site-language-container.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine.js+1 −1
- typo3/sysext/core/Resources/Private/Language/locallang_core.xlf+4 −4
- typo3/sysext/core/Resources/Private/Language/locallang_mod_web_list.xlf+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/Recycler/RecyclerModuleCest.php+1 −1
- typo3/sysext/filelist/Classes/ContextMenu/ItemProviders/FileProvider.php+18 −10
- typo3/sysext/filelist/Classes/FileList.php+12 −4
Review log 4667
Show 2642 earlier messages
-
Jochen Roth uploaded patch set 1 10/27/21, 20:09
-
core-ci voted on patch set 1 V +1 10/27/21, 20:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18631
-
Jochen Roth rebased onto patch set 2 10/29/21, 13:28
-
core-ci voted on patch set 2 V +1 10/29/21, 13:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18653
-
Oli Bartsch commented on patch set 2 CR -1 11/10/21, 12:42
InlineControlContainer.ts:465This will fail in case the label does not exist "Uncaught TypeError: Cannot read properties of undefined (reading 'replace')"InlineRecordContainer.php:593In case $data['databaseRow']['uid_local'][0]['title'] does not exists, this leads to an leading whitespace in the message.GridColumnItem.php:137Could we somehow improve this message. It currently looks like this: (There are 1 reference(s) to this record!) (This record has 1 translation(s) which will be deleted, too!) Maybe we can do this in only one sentence or at least somehow remove the duplicated parentheses.GridColumnItem.php:349return type missingGridColumnItem.php:353Can we just return the result of getNumberOfReferencedRecords()? I don't get the next two lines, since the result is added to a new array which is then directly returned. Also the null coalesce seems superfluous since getNumberOfReferencedRecords() always returns int.locallang_alt_doc.xlf:132All usages of this label have to be adjusted. At least SiteLanguageContainer is using it, too.locallang_layout.xlf:48Could you please check that all label usages are being adjusted.FormEngine.js:1127We might want to omit this by using htmlspecialchars in the controller. -
Jochen Roth uploaded patch set 3 11/17/21, 14:12
-
core-ci voted on patch set 3 V -1 11/17/21, 14:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19404
-
Jochen Roth uploaded patch set 4 11/17/21, 16:47
-
core-ci voted on patch set 4 V +1 11/17/21, 17:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19415
-
Jochen Roth commented on patch set 4 11/17/21, 18:08
InlineControlContainer.ts:465ReplyDoneInlineControlContainer.ts:465ReplyNo, removed it.InlineRecordContainer.php:593ReplyDoneGridColumnItem.php:137ReplyRemoved the duplicated parentheses.GridColumnItem.php:349ReplyDoneGridColumnItem.php:353ReplyDonelocallang_alt_doc.xlf:132ReplyDoneFormEngine.js:1127ReplyDone -
Benni Mack updated the commit message in patch set 5 11/18/21, 10:51
-
core-ci voted on patch set 5 V +1 11/18/21, 12:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19493
-
Jochen Roth uploaded patch set 6 11/25/21, 10:26
-
core-ci voted on patch set 6 V -1 11/25/21, 10:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19725
-
Oli Bartsch commented on patch set 6 11/25/21, 10:48
SiteLanguageContainer.ts:234;)EditDocumentController.php:1738Sorry, looking at the below lines the htmlspecialchars seems to be superfluous in this case. FormEngine uses them for a confirm modal where the content is automatically encoded.InlineRecordContainer.php:596Could this key be undefined?locallang_layout.xlf:48ReplyDoneFormEngine.js:35This should be removed as it's not defined nor used. -
Jochen Roth uploaded patch set 7 11/25/21, 10:57
-
core-ci voted on patch set 7 V +1 11/25/21, 11:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19727
-
Jochen Roth uploaded patch set 8 11/25/21, 12:28
-
Jochen Roth commented on patch set 7 11/25/21, 12:31
SiteLanguageContainer.ts:234ReplyAckEditDocumentController.php:1738ReplyAckInlineRecordContainer.php:596ReplyAdded a fallback just in case. But was defined while testing all the time.FormEngine.js:35ReplyDone -
core-ci voted on patch set 8 V -1 11/25/21, 12:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19732
-
Jochen Roth uploaded patch set 9 11/25/21, 13:35
-
core-ci voted on patch set 9 V +1 11/25/21, 13:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19737
-
Benni Mack commented on patch set 9 11/25/21, 19:51
PageLayoutView.php:1028do we need the $refCountMsg again then? -
Jochen Roth uploaded patch set 10 11/26/21, 14:30
-
core-ci voted on patch set 10 V +1 11/26/21, 14:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19793
-
Andreas Kienast commented on patch set 10 11/26/21, 14:54
EditDocumentController.php:1726What about this one? It would replace the whole if/else: $title = trim($this->storeTitle . ' [' . $this->firstEl['table'] . ':' . $this->firstEl['uid'] . ']');InlineRecordContainer.php:595In cases like these I'm a huge fan of sprintf(), but that's just a personal matter.GridColumnItem.php:151``` $recordInfo = trim(($this->record['header'] ?? '') . ' [' . $table . ':' . $this->record['uid'] . ']'); ``` or an sprintf() equivalentlocallang_alt_doc.xlf:133This sounds like broken grammar, "this" already points to a specific record. "... delete the record '%s'" is IMO better. -
Benni Mack wrote 11/29/21, 10:20
Change destination moved from master to main -
Benni Mack updated the commit message in patch set 11 11/29/21, 11:57
-
core-ci voted on patch set 11 V +1 11/29/21, 12:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19979
-
Jochen Roth uploaded patch set 12 12/13/21, 13:48
-
core-ci voted on patch set 12 V +1 12/13/21, 14:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21031
-
Jochen Roth commented on patch set 12 12/13/21, 14:13
EditDocumentController.php:1726ReplyDoneInlineRecordContainer.php:595ReplyOk, got rid of the if-statement for better readability.GridColumnItem.php:151ReplyDonePageLayoutView.php:1028ReplyNope.locallang_alt_doc.xlf:133ReplyDone -
Jochen Roth uploaded patch set 13 01/10/22, 12:27
-
core-ci voted on patch set 13 V +1 01/10/22, 12:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21849
-
Simon Schaufelberger uploaded patch set 14 06/10/22, 12:04
-
core-ci voted on patch set 14 V -1 06/10/22, 12:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27918
-
Simon Schaufelberger uploaded patch set 15 06/10/22, 12:16
-
core-ci voted on patch set 15 V -1 06/10/22, 12:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27920
-
core-ci voted on patch set 15 V +1 06/10/22, 14:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27920
-
André Buchmann voted on patch set 15 V +1 CR +1 06/11/22, 19:34
-
Riccardo De Contardi voted on patch set 15 V +1 07/09/22, 14:42
-
Nikita Hovratov voted on patch set 15 V +1 CR +1 07/10/22, 15:11
-
Oli Bartsch commented on patch set 15 CR -1 07/11/22, 08:36
The JavaScript file changes looks strange to me. -
Oli Bartsch commented on patch set 15 CR 0 07/11/22, 08:37
never mind, compared two patchsets ... -
Oli Bartsch commented on patch set 15 CR -1 07/11/22, 09:05
Title placeholder in FormEngine message is no longer replaced. Also this should be main only. -
Oli Bartsch uploaded patch set 16 07/11/22, 10:28
-
core-ci voted on patch set 16 V -1 07/11/22, 10:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28877
-
Oli Bartsch uploaded patch set 17 07/11/22, 11:19
-
core-ci voted on patch set 17 V +1 07/11/22, 11:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28880
-
Oli Bartsch commented on patch set 17 V +1 CR +1 07/11/22, 11:32
Reply
Done -
Oli Bartsch voted on patch set 17 V 0 CR -1 07/11/22, 14:41
-
Oliver Hader commented on patch set 17 07/11/22, 14:43
form-engine.ts:1136space missing here?InlineRecordContainer.php:661What about moving this to BE_USER? e.g. `BackendUserAuthentication::shallShowDebugInformation()` -
Oli Bartsch commented on patch set 17 07/11/22, 15:05
-
Oli Bartsch uploaded patch set 18 07/12/22, 07:54
-
Oli Bartsch uploaded patch set 19 07/12/22, 07:59
-
Oli Bartsch voted on patch set 19 V +1 CR +1 07/12/22, 08:03
-
Oli Bartsch commented on patch set 19 07/12/22, 08:03
form-engine.ts:1136ReplyDoneInlineRecordContainer.php:661ReplyDone -
core-ci voted on patch set 19 V +1 07/12/22, 08:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28944
-
core-ci voted on patch set 18 V +1 07/12/22, 08:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28940
-
Andreas Kienast commented on patch set 19 V -1 07/12/22, 08:30
Deleting a FAL record (tested with "inline fal") results in "Are you sure you want to delete the record 'undefined'?" -
Andreas Kienast uploaded patch set 20 07/12/22, 08:39
-
Andreas Kienast voted on patch set 20 V +1 CR +1 07/12/22, 08:39
-
Oli Bartsch voted on patch set 20 V +1 CR +1 07/12/22, 08:43
-
core-ci voted on patch set 20 V +1 07/12/22, 08:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28947
-
Jochen Roth voted on patch set 20 V +1 CR +1 07/12/22, 09:56
-
Andreas Kienast voted on patch set 20 V +2 CR +2 07/12/22, 09:56
-
Andreas Kienast merged patch set 21 07/12/22, 09:56
InlineControlContainer.ts:465