Review main Merged

72001[TASK] Streamline delete message for page and list view

Jochen Roth CR +2 V +2 Normal +136 −52 updated 07/12/22, 09:56

Commit message

The list and page view currently do not show
details about the record to be deleted.

The content of the delete modal has been enhanced with
record title and relations (if one does exist) and
the buttons and modal title now use the same labels.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Jochen Roth +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • core-ci +1 CI

Issues 2

Files 21

Show 1 more file

Review log 4667

Show 2642 earlier messages
  1. Jochen Roth uploaded patch set 1 10/27/21, 20:09

  2. core-ci voted on patch set 1 V +1 10/27/21, 20:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18631

  3. Jochen Roth rebased onto patch set 2 10/29/21, 13:28

  4. core-ci voted on patch set 2 V +1 10/29/21, 13:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18653

  5. Oli Bartsch commented on patch set 2 CR -1 11/10/21, 12:42

    InlineControlContainer.ts:465

    Do we really need this, since the value is htmlspecialchar'd in the InlineRecordContainer already.

    InlineControlContainer.ts:465

    This will fail in case the label does not exist "Uncaught TypeError: Cannot read properties of undefined (reading 'replace')"

    InlineRecordContainer.php:593

    In case $data['databaseRow']['uid_local'][0]['title'] does not exists, this leads to an leading whitespace in the message.

    GridColumnItem.php:137

    Could we somehow improve this message. It currently looks like this: (There are 1 reference(s) to this record!) (This record has 1 translation(s) which will be deleted, too!) Maybe we can do this in only one sentence or at least somehow remove the duplicated parentheses.

    GridColumnItem.php:349

    return type missing

    GridColumnItem.php:353

    Can we just return the result of getNumberOfReferencedRecords()? I don't get the next two lines, since the result is added to a new array which is then directly returned. Also the null coalesce seems superfluous since getNumberOfReferencedRecords() always returns int.

    locallang_alt_doc.xlf:132

    All usages of this label have to be adjusted. At least SiteLanguageContainer is using it, too.

    locallang_layout.xlf:48

    Could you please check that all label usages are being adjusted.

    FormEngine.js:1127

    We might want to omit this by using htmlspecialchars in the controller.
  6. Jochen Roth uploaded patch set 3 11/17/21, 14:12

  7. core-ci voted on patch set 3 V -1 11/17/21, 14:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19404

  8. Jochen Roth uploaded patch set 4 11/17/21, 16:47

  9. core-ci voted on patch set 4 V +1 11/17/21, 17:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19415

  10. Jochen Roth commented on patch set 4 11/17/21, 18:08

    InlineControlContainer.ts:465 Reply

    Done

    InlineControlContainer.ts:465 Reply

    No, removed it.

    InlineRecordContainer.php:593 Reply

    Done

    GridColumnItem.php:137 Reply

    Removed the duplicated parentheses.

    GridColumnItem.php:349 Reply

    Done

    GridColumnItem.php:353 Reply

    Done

    locallang_alt_doc.xlf:132 Reply

    Done

    FormEngine.js:1127 Reply

    Done
  11. Benni Mack updated the commit message in patch set 5 11/18/21, 10:51

  12. core-ci voted on patch set 5 V +1 11/18/21, 12:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19493

  13. Jochen Roth uploaded patch set 6 11/25/21, 10:26

  14. core-ci voted on patch set 6 V -1 11/25/21, 10:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19725

  15. Oli Bartsch commented on patch set 6 11/25/21, 10:48

    SiteLanguageContainer.ts:234

    ;)

    EditDocumentController.php:1738

    Sorry, looking at the below lines the htmlspecialchars seems to be superfluous in this case. FormEngine uses them for a confirm modal where the content is automatically encoded.

    InlineRecordContainer.php:596

    Could this key be undefined?

    locallang_layout.xlf:48 Reply

    Done

    FormEngine.js:35

    This should be removed as it's not defined nor used.
  16. Jochen Roth uploaded patch set 7 11/25/21, 10:57

  17. core-ci voted on patch set 7 V +1 11/25/21, 11:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19727

  18. Jochen Roth uploaded patch set 8 11/25/21, 12:28

  19. Jochen Roth commented on patch set 7 11/25/21, 12:31

    SiteLanguageContainer.ts:234 Reply

    Ack

    EditDocumentController.php:1738 Reply

    Ack

    InlineRecordContainer.php:596 Reply

    Added a fallback just in case. But was defined while testing all the time.

    FormEngine.js:35 Reply

    Done
  20. core-ci voted on patch set 8 V -1 11/25/21, 12:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19732

  21. Jochen Roth uploaded patch set 9 11/25/21, 13:35

  22. core-ci voted on patch set 9 V +1 11/25/21, 13:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19737

  23. Benni Mack commented on patch set 9 11/25/21, 19:51

    PageLayoutView.php:1028

    do we need the $refCountMsg again then?
  24. Jochen Roth uploaded patch set 10 11/26/21, 14:30

  25. core-ci voted on patch set 10 V +1 11/26/21, 14:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19793

  26. Andreas Kienast commented on patch set 10 11/26/21, 14:54

    EditDocumentController.php:1726

    What about this one? It would replace the whole if/else: $title = trim($this->storeTitle . ' [' . $this->firstEl['table'] . ':' . $this->firstEl['uid'] . ']');

    InlineRecordContainer.php:595

    In cases like these I'm a huge fan of sprintf(), but that's just a personal matter.

    GridColumnItem.php:151

    ``` $recordInfo = trim(($this->record['header'] ?? '') . ' [' . $table . ':' . $this->record['uid'] . ']'); ``` or an sprintf() equivalent

    locallang_alt_doc.xlf:133

    This sounds like broken grammar, "this" already points to a specific record. "... delete the record '%s'" is IMO better.
  27. Benni Mack wrote 11/29/21, 10:20

    Change destination moved from master to main
  28. Benni Mack updated the commit message in patch set 11 11/29/21, 11:57

  29. core-ci voted on patch set 11 V +1 11/29/21, 12:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19979

  30. Jochen Roth uploaded patch set 12 12/13/21, 13:48

  31. core-ci voted on patch set 12 V +1 12/13/21, 14:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21031

  32. Jochen Roth commented on patch set 12 12/13/21, 14:13

    EditDocumentController.php:1726 Reply

    Done

    InlineRecordContainer.php:595 Reply

    Ok, got rid of the if-statement for better readability.

    GridColumnItem.php:151 Reply

    Done

    PageLayoutView.php:1028 Reply

    Nope.

    locallang_alt_doc.xlf:133 Reply

    Done
  33. Jochen Roth uploaded patch set 13 01/10/22, 12:27

  34. core-ci voted on patch set 13 V +1 01/10/22, 12:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21849

  35. Simon Schaufelberger uploaded patch set 14 06/10/22, 12:04

  36. core-ci voted on patch set 14 V -1 06/10/22, 12:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27918

  37. Simon Schaufelberger uploaded patch set 15 06/10/22, 12:16

  38. core-ci voted on patch set 15 V -1 06/10/22, 12:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27920

  39. core-ci voted on patch set 15 V +1 06/10/22, 14:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/27920

  40. André Buchmann voted on patch set 15 V +1 CR +1 06/11/22, 19:34

  41. Riccardo De Contardi voted on patch set 15 V +1 07/09/22, 14:42

  42. Nikita Hovratov voted on patch set 15 V +1 CR +1 07/10/22, 15:11

  1. Oli Bartsch commented on patch set 15 CR -1 07/11/22, 08:36

    The JavaScript file changes looks strange to me.
  2. Oli Bartsch commented on patch set 15 CR 0 07/11/22, 08:37

    never mind, compared two patchsets ...
  3. Oli Bartsch commented on patch set 15 CR -1 07/11/22, 09:05

    Title placeholder in FormEngine message is no longer replaced. Also this should be main only.
  4. Oli Bartsch uploaded patch set 16 07/11/22, 10:28

  5. core-ci voted on patch set 16 V -1 07/11/22, 10:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28877

  6. Oli Bartsch uploaded patch set 17 07/11/22, 11:19

  7. core-ci voted on patch set 17 V +1 07/11/22, 11:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28880

  8. Oli Bartsch commented on patch set 17 V +1 CR +1 07/11/22, 11:32

    Reply

    Done
  9. Oli Bartsch voted on patch set 17 V 0 CR -1 07/11/22, 14:41

  10. Oliver Hader commented on patch set 17 07/11/22, 14:43

    form-engine.ts:1136

    space missing here?

    InlineRecordContainer.php:661

    What about moving this to BE_USER? e.g. `BackendUserAuthentication::shallShowDebugInformation()`
  11. Oli Bartsch commented on patch set 17 07/11/22, 15:05

  12. Oli Bartsch uploaded patch set 18 07/12/22, 07:54

  13. Oli Bartsch uploaded patch set 19 07/12/22, 07:59

  14. Oli Bartsch voted on patch set 19 V +1 CR +1 07/12/22, 08:03

  15. Oli Bartsch commented on patch set 19 07/12/22, 08:03

    form-engine.ts:1136 Reply

    Done

    InlineRecordContainer.php:661 Reply

    Done
  16. core-ci voted on patch set 19 V +1 07/12/22, 08:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28944

  17. core-ci voted on patch set 18 V +1 07/12/22, 08:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28940

  18. Andreas Kienast commented on patch set 19 V -1 07/12/22, 08:30

    Deleting a FAL record (tested with "inline fal") results in "Are you sure you want to delete the record 'undefined'?"
  19. Andreas Kienast uploaded patch set 20 07/12/22, 08:39

  20. Andreas Kienast voted on patch set 20 V +1 CR +1 07/12/22, 08:39

  21. Oli Bartsch voted on patch set 20 V +1 CR +1 07/12/22, 08:43

  22. core-ci voted on patch set 20 V +1 07/12/22, 08:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28947

  23. Jochen Roth voted on patch set 20 V +1 CR +1 07/12/22, 09:56

  24. Andreas Kienast voted on patch set 20 V +2 CR +2 07/12/22, 09:56

  25. Andreas Kienast merged patch set 21 07/12/22, 09:56