Review main Merged

72004[TASK] Streamline page tree delete modal

Jochen Roth CR +2 V +2 Easy +8 −5 updated 11/03/21, 16:31

Commit message

The page tree delete modal labels have been
changed to align with all other delete modals.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 3

Files 4

Review log 810

  1. Jochen Roth uploaded patch set 1 10/29/21, 14:11

  2. core-ci voted on patch set 1 V +1 10/29/21, 14:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18655

  3. Nikita Hovratov voted on patch set 1 V +1 CR +1 11/01/21, 16:04

  4. Anja Leichsenring commented on patch set 1 11/03/21, 12:12

    please also apply the change to pagetree -> context menu -> delete
  5. Jochen Roth uploaded patch set 2 11/03/21, 14:40

  6. core-ci voted on patch set 2 V +1 11/03/21, 15:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18788

  7. Anja Leichsenring voted on patch set 2 V +1 CR +1 11/03/21, 15:20

  8. Jochen Roth commented on patch set 2 11/03/21, 15:39

    Reply

    Done ... but for now the "drag & delete" does not include the related records. This will be added once we use AJAX to load the delete modals content.
  9. Christian Kuhn voted on patch set 2 V +2 CR +2 11/03/21, 16:31

  10. Christian Kuhn merged patch set 3 11/03/21, 16:31