Review main Merged

72013[BUGFIX] Sanitize calling htmlspecialchars(...) in TextareaViewHelper

Stefan Bürk CR +2 V +2 Easy +1 −1 updated 11/02/21, 13:05

Commit message

htmlspecialchars(...) expects that first argument is a string,
otherwise triggering E_DEPRECATED.

This patch adds a string cast to ensure value is passed as string
to htmlspecialchars(...) in TextareaViewHelper.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oliver Klee +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Stefan Bürk uploaded patch set 1 10/30/21, 18:30

  2. Oliver Klee voted on patch set 1 CR +1 10/30/21, 18:30

  3. core-ci voted on patch set 1 V +1 10/30/21, 18:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18685

  4. Georg Ringer voted on patch set 1 V +1 CR +1 11/01/21, 10:21

  5. Andreas Kienast updated the commit message in patch set 2 11/01/21, 10:39

  6. Andreas Kienast voted on patch set 2 V +1 CR +1 11/01/21, 10:39

  7. Oliver Klee voted on patch set 2 CR +1 11/01/21, 10:52

  8. core-ci voted on patch set 2 V +1 11/01/21, 11:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18715

  9. Nikita Hovratov voted on patch set 2 V +1 CR +1 11/01/21, 13:38

  10. Andreas Kienast voted on patch set 2 V +2 CR +2 11/02/21, 13:05

  11. Andreas Kienast merged patch set 3 11/02/21, 13:05