Review main Merged

72014[DOCS] Add README.rst as "about" file to system extensions

Lina Wolf CR +2 V +2 Normal +201 −9 updated 11/03/21, 14:11

Commit message

Fix links to system extension in composer.json documentation where it
was still missing. Remove reference to docs_indexed_search from indexed
search. It has not been updated since 2008.

Remove apostrophe from the verb "lets".

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Sybille Peters +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Sybille Peters +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 23

Review log 1620

  1. Lina Wolf uploaded patch set 1 10/31/21, 17:37

  2. Simon Gilli commented on patch set 1 10/31/21, 17:41

    README.md:14

    Same here ofc

    composer.json:14

    Would love to see a generic entry point instead e.g. https://docs.typo3.org/go/typo3/cms-adminpanel
  3. Sybille Peters commented on patch set 1 10/31/21, 17:50

    composer.json:14 Reply

    We debated that too. But I think especially the system extension documentation is a bit hidden, so actually I think it is good that it links directly to the sysext docs. IMHO.
  4. core-ci voted on patch set 1 V +1 10/31/21, 17:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18700

  5. Sybille Peters commented on patch set 1 V -1 10/31/21, 18:20

    README.md:2

    Formatting must be changed to Markdown or README.md changed to README.rst. Applies to all the READMEs.
  6. Lina Wolf commented on patch set 1 10/31/21, 19:48

    README.md:14 Reply Unresolved

    The same solution is already applied in sysextensions like indexed_search, workspaces, forms etc.

    composer.json:14 Reply Unresolved

    However the link https://docs.typo3.org/go/typo3/cms-adminpanel doesn't work yet. This would have to be another PR and it would have to be solved in the documentation. For now https://docs.typo3.org/c/typo3/cms-adminpanel/master/en-us/ is the most generic link that we have.
  7. Lina Wolf uploaded patch set 2 10/31/21, 19:53

  8. Lina Wolf commented on patch set 2 10/31/21, 19:54

    README.md:2 Reply

    Done
  9. core-ci voted on patch set 2 V +1 10/31/21, 20:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18708

  10. Sybille Peters commented on patch set 2 10/31/21, 22:12

    README.rst:15

    Should be indexed_search. Will push
  11. Sybille Peters uploaded patch set 3 10/31/21, 22:15

  12. Sybille Peters commented on patch set 3 V +1 CR +1 10/31/21, 22:17

    README.rst:15 Reply

    Done.
  13. core-ci voted on patch set 3 V +1 10/31/21, 22:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18709

  14. Nikita Hovratov uploaded patch set 4 11/01/21, 14:36

  15. Nikita Hovratov voted on patch set 4 V +1 CR +1 11/01/21, 14:38

  16. core-ci voted on patch set 4 V +1 11/01/21, 14:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18725

  17. Sybille Peters voted on patch set 4 V +1 CR +1 11/01/21, 15:08

  18. Sybille Peters commented on patch set 4 11/02/21, 07:13

    btw, the "lowlevel" extension has documentation too. It just needs to be activated. In this case it is a single-file-solution. But since it is not online yet, I would leave that to later (to add the link to composer.json). Documentation for EXT:redirect is in progress, can also be done later.
  19. Anja Leichsenring voted on patch set 4 V +2 CR +2 11/03/21, 14:10

  20. Anja Leichsenring merged patch set 5 11/03/21, 14:11