Review main Merged

72017[BUGFIX] Fix IRRE related undefined key warnings

Robert Kärner CR +2 V +2 Easy +3 −3 updated 11/03/21, 11:59

Commit message

Two occurrences in the DataHandler and another in
InlineRecordContainer needed fallbacks for array access.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Christian Spoo +1
    • Rudy Gnodde +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Christian Spoo +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 67

  1. Robert Kärner uploaded patch set 1 11/01/21, 12:25

  2. core-ci voted on patch set 1 V +1 11/01/21, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18721

  3. Christian Spoo commented on patch set 1 V +1 CR +1 11/01/21, 15:40

    Works for me and improves things a lot if allowedTables is configured incorrectly
  4. Oliver Klee voted on patch set 1 CR +1 11/01/21, 18:59

  5. Rudy Gnodde voted on patch set 1 CR +1 11/03/21, 10:25

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 11/03/21, 11:59

  7. Christian Kuhn merged patch set 2 11/03/21, 11:59