72023[TASK] Use dedicated JavaScript initialization for form manager
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Oli Bartsch +1
- Jochen Roth +1
-
Verified V +2 Done
- Oliver Hader +2
- Oli Bartsch +1
- Jochen Roth +1
- core-ci +1 CI
Issues 1
Files 5
- Build/Sources/TypeScript/form/Resources/Public/TypeScript/Backend/Helper.tsnew+57 −0
- typo3/sysext/form/Classes/Controller/FormEditorController.php1+13 −12
- typo3/sysext/form/Classes/Controller/FormManagerController.php1+16 −13
- typo3/sysext/form/Resources/Public/JavaScript/Backend/Helper.jsnew+13 −0
- typo3/sysext/form/Tests/Unit/Controller/FormManagerControllerTest.php+1 −1
Review log 710
-
Oliver Hader uploaded patch set 1 11/02/21, 13:01
-
core-ci voted on patch set 1 V -1 11/02/21, 13:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18754
-
Oliver Hader uploaded patch set 2 11/02/21, 13:11
-
core-ci voted on patch set 2 V -1 11/02/21, 13:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18757
-
Oliver Hader uploaded patch set 3 11/02/21, 14:41
-
core-ci voted on patch set 3 V +1 11/02/21, 14:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18762
-
Jochen Roth voted on patch set 3 V +1 CR +1 11/03/21, 15:00
-
Oli Bartsch commented on patch set 3 V +1 CR +1 11/03/21, 15:01
FormManagerController.php:102Unresolvedcould be static -
Oliver Hader voted on patch set 3 V +2 CR +2 11/03/21, 15:02
-
Oliver Hader merged patch set 4 11/03/21, 15:03
FormEditorController.php:155Unresolved