Review main Merged

72023[TASK] Use dedicated JavaScript initialization for form manager

Oliver Hader CR +2 V +2 Normal +100 −26 updated 11/03/21, 15:03

Commit message

To avoid having nested require.js inline JavaScript, initialization
of the form manager uses a dedicated helper module. This is a
preparation to reduce the amount of inline JavaScript later.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Oli Bartsch +1
    • Jochen Roth +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 710

  1. Oliver Hader uploaded patch set 1 11/02/21, 13:01

  2. core-ci voted on patch set 1 V -1 11/02/21, 13:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18754

  3. Oliver Hader uploaded patch set 2 11/02/21, 13:11

  4. core-ci voted on patch set 2 V -1 11/02/21, 13:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18757

  5. Oliver Hader uploaded patch set 3 11/02/21, 14:41

  6. core-ci voted on patch set 3 V +1 11/02/21, 14:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18762

  7. Jochen Roth voted on patch set 3 V +1 CR +1 11/03/21, 15:00

  8. Oli Bartsch commented on patch set 3 V +1 CR +1 11/03/21, 15:01

    FormEditorController.php:155 Unresolved

    could be static

    FormManagerController.php:102 Unresolved

    could be static
  9. Oliver Hader voted on patch set 3 V +2 CR +2 11/03/21, 15:02

  10. Oliver Hader merged patch set 4 11/03/21, 15:03