Review main Merged

72025[TASK] Normalize JavaScript initialization of workspaces preview

Oliver Hader CR +2 V +2 Easy +13 −23 updated 11/03/21, 15:17

Commit message

Ensures workspaces PreviewController uses dedicated method to declare
client-side settings PageRenderer::addInlineSetting(). This is a
preparation to reduce the amount of inline JavaScript later.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Oli Bartsch +1
    • Jochen Roth +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Oliver Hader uploaded patch set 1 11/02/21, 13:02

  2. core-ci voted on patch set 1 V -1 11/02/21, 13:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18756

  3. Oliver Hader uploaded patch set 2 11/02/21, 13:12

  4. core-ci voted on patch set 2 V +1 11/02/21, 13:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18758

  5. Oli Bartsch voted on patch set 2 V +1 CR +1 11/03/21, 15:10

  6. Jochen Roth voted on patch set 2 V +1 CR +1 11/03/21, 15:10

  7. Oliver Hader voted on patch set 2 V +2 CR +2 11/03/21, 15:17

  8. Oliver Hader merged patch set 3 11/03/21, 15:17