72026[TASK] Avoid using public property ModuleLoader::$modules
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Simon Gilli +1
- Anja Leichsenring +1
- Oliver Hader +1
-
Verified V +2 Done
- Oli Bartsch +2
- Anja Leichsenring +1
- core-ci +1 CI
Issues 1
Files 10
- typo3/sysext/backend/Classes/Backend/Shortcut/ShortcutRepository.php+2 −2
- typo3/sysext/backend/Classes/Controller/AboutController.php+3 −3
- typo3/sysext/backend/Classes/Controller/BackendController.php+1 −1
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+2 −2
- typo3/sysext/backend/Classes/Domain/Repository/Module/BackendModuleRepository.php+1 −1
- typo3/sysext/backend/Classes/Domain/Repository/TableManualRepository.php+1 −1
- typo3/sysext/backend/Classes/Module/ModuleLoader.php3+13 −2
- typo3/sysext/core/Classes/Hooks/TcaItemsProcessorFunctions.php+2 −2
- typo3/sysext/core/Tests/Unit/Hooks/TcaItemsProcessorFunctionsTest.php+4 −4
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php+1 −1
Review log 1114
-
Oliver Hader uploaded patch set 1 11/02/21, 15:48
-
Mathias Brodala commented on patch set 1 11/02/21, 16:03
-
core-ci voted on patch set 1 V -1 11/02/21, 16:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18763
-
Anja Leichsenring uploaded patch set 2 11/03/21, 12:01
-
Oliver Hader commented on patch set 2 11/03/21, 12:05
ModuleLoader.php:39Reply> Sounds like something for the PublicPropertyDeprecationTrait That's correct, but no deprecations for TYPO3 v11 anymore. For v12 (once the 11.5 branch exists), using the mentioned trait would be the way to go. -
Oli Bartsch updated the commit message in patch set 3 11/03/21, 12:05
-
core-ci voted on patch set 2 V +1 11/03/21, 12:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18779
-
Oliver Hader voted on patch set 3 CR +1 11/03/21, 12:19
-
Anja Leichsenring voted on patch set 3 V +1 CR +1 11/03/21, 12:19
-
core-ci voted on patch set 3 V +1 11/03/21, 12:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18781
-
Oli Bartsch voted on patch set 3 V +1 CR +1 11/03/21, 12:45
-
Simon Gilli commented on patch set 3 CR +1 11/03/21, 12:46
ModuleLoader.php:39Reply Unresolved> That's correct, but no deprecations for TYPO3 v11 anymore. Also for internal classes? -
Oli Bartsch voted on patch set 3 V +2 CR +2 11/03/21, 13:03
-
Oli Bartsch merged patch set 4 11/03/21, 13:04
ModuleLoader.php:39