Review main Merged

72026[TASK] Avoid using public property ModuleLoader::$modules

Oliver Hader CR +2 V +2 Easy +30 −19 updated 11/03/21, 13:04

Commit message

Changes read-access to modules from `ModuleLoader::$modules`
to `ModuleLoader::getModules()`.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Simon Gilli +1
    • Anja Leichsenring +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 1114

  1. Oliver Hader uploaded patch set 1 11/02/21, 15:48

  2. Mathias Brodala commented on patch set 1 11/02/21, 16:03

    ModuleLoader.php:39

    Sounds like something for the PublicPropertyDeprecationTrait
  3. core-ci voted on patch set 1 V -1 11/02/21, 16:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18763

  4. Anja Leichsenring uploaded patch set 2 11/03/21, 12:01

  5. Oliver Hader commented on patch set 2 11/03/21, 12:05

    ModuleLoader.php:39 Reply

    > Sounds like something for the PublicPropertyDeprecationTrait That's correct, but no deprecations for TYPO3 v11 anymore. For v12 (once the 11.5 branch exists), using the mentioned trait would be the way to go.
  6. Oli Bartsch updated the commit message in patch set 3 11/03/21, 12:05

  7. core-ci voted on patch set 2 V +1 11/03/21, 12:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18779

  8. Oliver Hader voted on patch set 3 CR +1 11/03/21, 12:19

  9. Anja Leichsenring voted on patch set 3 V +1 CR +1 11/03/21, 12:19

  10. core-ci voted on patch set 3 V +1 11/03/21, 12:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18781

  11. Oli Bartsch voted on patch set 3 V +1 CR +1 11/03/21, 12:45

  12. Simon Gilli commented on patch set 3 CR +1 11/03/21, 12:46

    ModuleLoader.php:39 Reply Unresolved

    > That's correct, but no deprecations for TYPO3 v11 anymore. Also for internal classes?
  13. Oli Bartsch voted on patch set 3 V +2 CR +2 11/03/21, 13:03

  14. Oli Bartsch merged patch set 4 11/03/21, 13:04