72029[BUGFIX] Allow service aliases in ContentDataProcessor
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 5
- typo3/sysext/frontend/Classes/ContentObject/ContentDataProcessor.php4+44 −15
- typo3/sysext/frontend/Configuration/Services.yaml+3 −0
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentDataProcessorTest.php+58 −3
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+5 −0
- typo3/sysext/frontend/Tests/Unit/ContentObject/FluidTemplateContentObjectTest.php+37 −0
Review log 1721
-
Benjamin Franzke uploaded patch set 1 11/03/21, 08:22
-
Simon Gilli commented on patch set 1 CR -1 11/03/21, 08:45
-
core-ci voted on patch set 1 V +1 11/03/21, 08:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18771
-
Benjamin Franzke uploaded patch set 2 11/03/21, 08:53
-
Benjamin Franzke commented on patch set 2 11/03/21, 08:53
ContentDataProcessor.php:29Replyyup, had to fix the unit tests first. Therefore the TODO in the container usage code. -
core-ci voted on patch set 2 V +1 11/03/21, 09:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18772
-
Benni Mack voted on patch set 2 CR +1 11/04/21, 13:25
-
Benjamin Franzke wrote 11/04/21, 17:02
Topic set to di -
Oli Bartsch voted on patch set 2 V +1 CR +1 11/08/21, 15:02
-
Simon Gilli commented on patch set 2 CR -1 11/08/21, 15:54
See comment, will try to comeup with a solution here...ContentDataProcessor.php:26I like to avoid SingletonInterace here and will have a look at the tests a bit later and see if I can provide a simple fix... -
Benjamin Franzke uploaded patch set 3 11/08/21, 16:20
-
Benjamin Franzke commented on patch set 3 11/08/21, 16:20
ContentDataProcessor.php:26ReplyDone -
core-ci voted on patch set 3 V +1 11/08/21, 16:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19030
-
Oli Bartsch voted on patch set 3 V +1 CR +1 11/11/21, 10:40
-
Benni Mack voted on patch set 3 V +1 CR +1 11/11/21, 10:40
-
Benni Mack commented on patch set 3 V 0 CR 0 11/11/21, 10:41
I think it would be nice to have Core's processors available directly as "dataProcessor.flexform" ? -
Benni Mack updated the commit message in patch set 4 11/11/21, 10:42
-
core-ci voted on patch set 4 V +1 11/11/21, 10:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19167
-
Benni Mack commented on patch set 4 V +1 CR +1 11/11/21, 12:18
Let's keep it as is for the time being -
Oli Bartsch voted on patch set 4 V +2 CR +2 11/11/21, 12:20
-
Oli Bartsch merged patch set 5 11/11/21, 12:20
ContentDataProcessor.php:29