Review main Merged

72029[BUGFIX] Allow service aliases in ContentDataProcessor

Benjamin Franzke CR +2 V +2 Normal +147 −18 updated 11/11/21, 12:20

Commit message

Fetch services from the DI container and perform post-creations
checks instead of checking class_exists and therefore exclude
possible service aliases defined in DI.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 1721

  1. Benjamin Franzke uploaded patch set 1 11/03/21, 08:22

  2. Simon Gilli commented on patch set 1 CR -1 11/03/21, 08:45

    ContentDataProcessor.php:29

    didn't you say mandatory for this case?
  3. core-ci voted on patch set 1 V +1 11/03/21, 08:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18771

  4. Benjamin Franzke uploaded patch set 2 11/03/21, 08:53

  5. Benjamin Franzke commented on patch set 2 11/03/21, 08:53

    ContentDataProcessor.php:29 Reply

    yup, had to fix the unit tests first. Therefore the TODO in the container usage code.
  6. core-ci voted on patch set 2 V +1 11/03/21, 09:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18772

  7. Benni Mack voted on patch set 2 CR +1 11/04/21, 13:25

  8. Benjamin Franzke wrote 11/04/21, 17:02

    Topic set to di
  9. Oli Bartsch voted on patch set 2 V +1 CR +1 11/08/21, 15:02

  10. Simon Gilli commented on patch set 2 CR -1 11/08/21, 15:54

    See comment, will try to comeup with a solution here...

    ContentDataProcessor.php:26

    I like to avoid SingletonInterace here and will have a look at the tests a bit later and see if I can provide a simple fix...
  11. Benjamin Franzke uploaded patch set 3 11/08/21, 16:20

  12. Benjamin Franzke commented on patch set 3 11/08/21, 16:20

    ContentDataProcessor.php:26 Reply

    Done
  13. core-ci voted on patch set 3 V +1 11/08/21, 16:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19030

  14. Oli Bartsch voted on patch set 3 V +1 CR +1 11/11/21, 10:40

  15. Benni Mack voted on patch set 3 V +1 CR +1 11/11/21, 10:40

  16. Benni Mack commented on patch set 3 V 0 CR 0 11/11/21, 10:41

    I think it would be nice to have Core's processors available directly as "dataProcessor.flexform" ?
  17. Benni Mack updated the commit message in patch set 4 11/11/21, 10:42

  18. core-ci voted on patch set 4 V +1 11/11/21, 10:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19167

  19. Benni Mack commented on patch set 4 V +1 CR +1 11/11/21, 12:18

    Let's keep it as is for the time being
  20. Oli Bartsch voted on patch set 4 V +2 CR +2 11/11/21, 12:20

  21. Oli Bartsch merged patch set 5 11/11/21, 12:20