Review main Merged

72033[BUGFIX] Fix undefined key warning in EXT:form with PHP8

Florian Rival CR +2 V +2 Easy +4 −3 updated 11/03/21, 16:10

Commit message

When using a form witch contains a fieldset element,
you will have a PHP warning:
Undefined array key "xs" in GridColumnClassAutoConfigurationViewHelper.php

This was only a notice with PHP v7 but it's an error with PHP v8.
This bugfix corrects the usage of undefined array keys.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 69

  1. Florian Rival uploaded patch set 1 11/03/21, 13:28

  2. core-ci voted on patch set 1 V +1 11/03/21, 13:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18784

  3. Benni Mack updated the commit message in patch set 2 11/03/21, 15:39

  4. Benni Mack updated the commit message in patch set 3 11/03/21, 15:39

  5. Jochen Roth voted on patch set 3 V +1 CR +1 11/03/21, 15:57

  6. core-ci voted on patch set 2 V +1 11/03/21, 16:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18795

  7. core-ci voted on patch set 3 V +1 11/03/21, 16:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18796

  8. Anja Leichsenring voted on patch set 3 V +2 CR +2 11/03/21, 16:10

  9. Anja Leichsenring merged patch set 4 11/03/21, 16:10