Review main Merged

72034[BUGFIX] Input and save date properly when USdateFormat is set

Gabe Troyan CR +2 V +2 Easy +2 −1 updated 11/11/21, 15:01

Commit message

Currently, the value of `USdateFormat` is disregarded because the
corresponding property, `FormEngineValidation.USmode`, is set to zero
regardless in `FormEngineValidation.initialize()`. This change will ensure
that `USmode` will remain 1 without conflicting with core functionality
that relies on `USmode` being set *before* `initialize()` is called.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 913

  1. Gabe Troyan uploaded patch set 1 11/03/21, 13:55

  2. core-ci voted on patch set 1 V +1 11/03/21, 14:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18786

  3. Benni Mack updated the commit message in patch set 2 11/03/21, 15:30

  4. core-ci voted on patch set 2 V +1 11/03/21, 15:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18793

  5. Benni Mack voted on patch set 2 CR +1 11/03/21, 17:15

  6. Gabe Troyan uploaded patch set 3 11/03/21, 18:46

  7. core-ci voted on patch set 3 V +1 11/03/21, 19:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18811

  8. Benni Mack updated the commit message in patch set 4 11/05/21, 15:39

  9. Benni Mack voted on patch set 4 V +1 CR +1 11/05/21, 15:39

  10. core-ci voted on patch set 4 V +1 11/05/21, 15:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18959

  11. Oli Bartsch voted on patch set 4 V +1 CR +1 11/11/21, 14:40

  12. Benni Mack voted on patch set 4 V +2 CR +2 11/11/21, 15:01

  13. Benni Mack merged patch set 5 11/11/21, 15:01