Review main Merged

72038[BUGFIX] Fix Environment overview with using SQLite

Maik Beckmann CR +2 V +2 Easy +3 −3 updated 11/03/21, 17:32

Commit message

This change allows for the db connection parameters 'user',
'host' and 'port' to be empty, as it happens when using SQLite.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1216

  1. Maik Beckmann uploaded patch set 1 11/03/21, 16:34

  2. Benni Mack updated the commit message in patch set 2 11/03/21, 16:46

  3. Benni Mack voted on patch set 2 V +1 CR +1 11/03/21, 16:46

  4. Simon Gilli updated the commit message in patch set 3 11/03/21, 16:46

  5. Simon Gilli commented on patch set 3 V +1 CR +1 11/03/21, 16:47

    Thanks for your first patch!
  6. Stefan Bürk commented on patch set 3 V +1 CR +1 11/03/21, 16:48

    Thx for the patch. Works as intended.
  7. core-ci voted on patch set 1 V +1 11/03/21, 16:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18797

  8. core-ci voted on patch set 2 V +1 11/03/21, 17:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18798

  9. core-ci voted on patch set 3 V +1 11/03/21, 17:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18799

  10. Christian Kuhn updated the commit message in patch set 4 11/03/21, 17:08

  11. Stefan Bürk voted on patch set 4 V +1 CR +1 11/03/21, 17:10

  12. Christian Kuhn voted on patch set 4 V +1 CR +1 11/03/21, 17:10

  13. Benni Mack voted on patch set 4 V +1 CR +1 11/03/21, 17:15

  14. core-ci voted on patch set 4 V +1 11/03/21, 17:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18803

  15. Christian Kuhn voted on patch set 4 V +2 CR +2 11/03/21, 17:32

  16. Christian Kuhn merged patch set 5 11/03/21, 17:32