Review main Merged

72042[BUGFIX] Replace filter_var(FILTER_SANITIZE_STRING) in RequestBuilder

Stefan Bürk CR +2 V +2 Easy +3 −3 updated 11/04/21, 10:57

Commit message

Sanitize filter 'FILTER_SANITIZE_STRING' has been deprecated
since PHP 8.1 and will be removed in PHP 9.

ext:extbase RequestBuilder has used this depcrecated filter
to sanitize values, thus creating E_DEPRECATED warnings.

This patch replaces this filter with alnum preg_replace(...)
calls, except for $controllerName where backslash is allowed.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Stefan Bürk uploaded patch set 1 11/03/21, 21:29

  2. core-ci voted on patch set 1 V +1 11/03/21, 21:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18841

  3. Anja Leichsenring voted on patch set 1 V +1 CR +1 11/04/21, 09:45

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 11/04/21, 10:57

  5. Christian Kuhn merged patch set 2 11/04/21, 10:57