72044[BUGFIX] Translate image dimensions on file replace
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Jochen Roth +1
- André Buchmann +1
-
Verified V +2 Done
- Benni Mack +2
- Jochen Roth +1
- André Buchmann +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1420
-
André Buchmann uploaded patch set 1 11/04/21, 07:22
-
core-ci voted on patch set 1 V -1 11/04/21, 07:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18848
-
André Buchmann uploaded patch set 2 11/04/21, 07:28
-
core-ci voted on patch set 2 V +1 11/04/21, 07:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18850
-
Jochen Roth commented on patch set 2 11/04/21, 09:49
-
Jochen Roth uploaded patch set 3 11/04/21, 10:45
-
Jochen Roth commented on patch set 3 11/04/21, 10:46
MetaDataEventListener.php:56ReplyDone -
core-ci voted on patch set 3 V +1 11/04/21, 11:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18861
-
Benni Mack updated the commit message in patch set 4 11/04/21, 15:39
-
Benni Mack updated the commit message in patch set 5 11/04/21, 15:40
-
Benni Mack commented on patch set 5 11/04/21, 15:40
MetaDataEventListener.php:24should be internal, I'd say. We can also make it final -
core-ci voted on patch set 4 V +1 11/04/21, 15:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18900
-
core-ci voted on patch set 5 V +1 11/04/21, 16:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18901
-
Jochen Roth uploaded patch set 6 11/04/21, 16:27
-
André Buchmann commented on patch set 6 11/04/21, 16:29
MetaDataEventListener.php:24ReplyCan be final from my opinion. Jochen was faster :-D -
André Buchmann commented on patch set 6 V +1 CR +1 11/04/21, 16:43
MetaDataEventListener.php:24ReplyDone -
core-ci voted on patch set 6 V +1 11/04/21, 16:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18911
-
Jochen Roth voted on patch set 6 V +1 CR +1 11/05/21, 08:46
-
Benni Mack voted on patch set 6 V +2 CR +2 11/05/21, 11:22
-
Benni Mack merged patch set 7 11/05/21, 11:22
MetaDataEventListener.php:56