Review main Merged

72050[BUGFIX] Do not show empty colPos message for special unused column

Oli Bartsch CR +2 V +2 Easy +13 −9 updated 11/04/21, 13:38

Commit message

Columns, not having a colPos defined, are considered as
inaccessible. A event listener therefore enriches such
columns with a corresponding information in the page
module. Since the special "unused elements" column is
obviously also missing the "colPos", the information
was previously also shown for this column.

This is now fixed by checking for the special "unused"
column, before enriching the columns markup.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Oli Bartsch uploaded patch set 1 11/04/21, 12:07

  2. core-ci voted on patch set 1 V +1 11/04/21, 12:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18874

  3. Jochen Roth voted on patch set 1 V +1 CR +1 11/04/21, 13:06

  4. Benni Mack voted on patch set 1 V +1 CR +1 11/04/21, 13:16

  5. Oli Bartsch voted on patch set 1 V +2 CR +2 11/04/21, 13:38

  6. Oli Bartsch merged patch set 2 11/04/21, 13:38