72056[TASK] Simplify checkbox items TCA
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 29
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaCheckboxItems.php+0 −1
- typo3/sysext/backend/Configuration/SiteConfiguration/site_language.php+0 −6
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaCheckboxItemsTest.php+1 −19
- typo3/sysext/backend/Tests/Unit/Utility/BackendUtilityTest.php+0 −2
- typo3/sysext/core/Configuration/TCA/be_groups.php+1 −5
- typo3/sysext/core/Configuration/TCA/be_users.php+3 −13
- typo3/sysext/core/Configuration/TCA/pages.php+2 −35
- typo3/sysext/core/Configuration/TCA/sys_category.php+0 −1
- typo3/sysext/core/Configuration/TCA/sys_filemounts.php+0 −7
- typo3/sysext/core/Configuration/TCA/sys_file_collection.php+0 −6
- typo3/sysext/core/Configuration/TCA/sys_file_reference.php+0 −6
- typo3/sysext/core/Configuration/TCA/sys_file_storage.php+0 −30
- typo3/sysext/core/Configuration/TCA/sys_language.php+0 −1
- typo3/sysext/core/Configuration/TCA/sys_news.php+0 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_datahandler/Configuration/TCA/Overrides/tt_content.php+1 −1
- typo3/sysext/dashboard/Configuration/TCA/be_dashboards.php+0 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/tx_blogexample_domain_model_info.php+0 −1
- typo3/sysext/frontend/Configuration/TCA/backend_layout.php+0 −1
- typo3/sysext/frontend/Configuration/TCA/fe_groups.php+0 −1
- typo3/sysext/frontend/Configuration/TCA/fe_users.php+0 −1
Show 9 more files
- typo3/sysext/frontend/Configuration/TCA/sys_template.php+2 −15
- typo3/sysext/frontend/Configuration/TCA/tt_content.php+0 −55
- typo3/sysext/indexed_search/Configuration/TCA/index_config.php+0 −7
- typo3/sysext/redirects/Configuration/TCA/sys_redirect.php+0 −32
- typo3/sysext/scheduler/Configuration/TCA/tx_scheduler_task_group.php+0 −1
- typo3/sysext/seo/Configuration/TCA/Overrides/pages.php+2 −4
- typo3/sysext/sys_note/Configuration/TCA/sys_note.php+0 −6
- typo3/sysext/workspaces/Configuration/TCA/sys_workspace.php+17 −29
- typo3/sysext/workspaces/Configuration/TCA/sys_workspace_stage.php+6 −6
Review log 78
-
Nikita Hovratov uploaded patch set 1 11/04/21, 19:51
-
core-ci voted on patch set 1 V +1 11/04/21, 20:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18917
-
Benni Mack voted on patch set 1 CR +1 11/05/21, 12:01
-
Christian Kuhn voted on patch set 1 V +1 CR +1 11/09/21, 17:37
-
Oli Bartsch commented on patch set 1 11/09/21, 18:07
I really like this simplification. However, in case I want to add configuration to an item, I still have to add superfluous array keys / values. Given following config: 'config' => [ 'type' => 'check', 'renderType' => 'checkboxToggle', 'items' => [ [ 'invertStateDisplay' => true, ], ], ], This will lead to "Item 0 of field my_field of TCA my_table has no label" exception. It therefore requires to add the key 0 with at least an empty string. 'config' => [ 'type' => 'check', 'renderType' => 'checkboxToggle', 'items' => [ [ 0 => '', 'invertStateDisplay' => true, ], ], ], Do we want to tackle this here, too? -
Nikita Hovratov commented on patch set 1 11/09/21, 18:17
Reply
Yes you're right. I would say we tackle it in another patch. This is just cleanup, which adds no functionality. Probably something for v12. -
Benni Mack voted on patch set 1 V +2 CR +2 11/10/21, 09:13
-
Benni Mack merged patch set 2 11/10/21, 09:13