72058[BUGFIX] Fix undefined key warning in EXT:frontend with PHP8
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Nikita Hovratov +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1519
-
Florian Rival uploaded patch set 1 11/05/21, 10:35
-
Andreas Kienast voted on patch set 1 V +1 CR +1 11/05/21, 10:43
-
core-ci voted on patch set 1 V -1 11/05/21, 10:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18936
-
Oli Bartsch commented on patch set 1 11/05/21, 10:57
-
core-ci voted on patch set 1 V +1 11/05/21, 12:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18936
-
Florian Rival commented on patch set 1 11/05/21, 13:55
ContentObjectRenderer.php:3481ReplyNot really sure for that one, could also be 'false' instead of empty string because the only test with this value is a check to assert it's an array (line 3482) is_array($stdWrap). -
Andreas Kienast commented on patch set 1 11/05/21, 15:39
ContentObjectRenderer.php:3481ReplyI'd go with `null` then -
Andreas Kienast uploaded patch set 2 11/05/21, 15:45
-
Andreas Kienast voted on patch set 2 V +1 CR +1 11/05/21, 15:46
-
core-ci voted on patch set 2 V +1 11/05/21, 16:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18961
-
Benni Mack commented on patch set 1 CR -1 11/05/21, 16:33
ContentObjectRenderer.php:3481Replyit's wrong. it's "tagStdWrap" but before it was stdWrap. please fix -
Andreas Kienast uploaded patch set 3 11/05/21, 16:39
-
core-ci voted on patch set 3 V +1 11/05/21, 16:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18964
-
Benni Mack voted on patch set 3 CR +1 11/05/21, 19:50
-
Benni Mack commented on patch set 3 11/05/21, 19:50
ContentObjectRenderer.php:3481ReplyDone -
Christian Kuhn voted on patch set 3 V +1 CR +1 11/09/21, 17:11
-
Nikita Hovratov voted on patch set 3 V +1 CR +1 11/09/21, 18:36
-
Christian Kuhn voted on patch set 3 V +2 CR +2 11/09/21, 18:47
-
Christian Kuhn merged patch set 4 11/09/21, 18:47
ContentObjectRenderer.php:3481