Review 10.4 Merged

72060[BUGFIX] Add missing cookie option on install tool logout

Christian Kuhn CR +2 V +2 Easy +11 −6 updated 11/08/21, 11:40

Commit message

Add the missing samesite cookie option after the logout from the
install tool which leads to an error in the browser console.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Christian Kuhn uploaded patch set 1 11/05/21, 11:07

  2. core-ci voted on patch set 1 V -1 11/05/21, 11:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18939

  3. Christian Kuhn commented on patch set 1 11/05/21, 12:07

    fails since symfony cookie object is quite different in older versions. simon will try to come up with something.
  4. Simon Gilli uploaded patch set 2 11/06/21, 10:39

  5. core-ci voted on patch set 2 V +1 11/06/21, 10:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18977

  6. Christian Kuhn voted on patch set 2 V +2 CR +2 11/08/21, 11:40

  7. Christian Kuhn merged patch set 3 11/08/21, 11:40