72061[TASK] Explicitly use JavaScript module instructions in dashboard
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/dashboard/Classes/Controller/DashboardController.php+9 −2
- typo3/sysext/dashboard/Classes/Widgets/BarChartWidget.php+5 −4
- typo3/sysext/dashboard/Classes/Widgets/DoughnutChartWidget.php+5 −4
- typo3/sysext/dashboard/Classes/Widgets/JavaScriptInterface.phpnew+31 −0
- typo3/sysext/dashboard/Classes/Widgets/RequireJsModuleInterface.php+3 −1
- typo3/sysext/dashboard/Classes/DashboardInitializationService.php+28 −2
Review log 68
-
Oliver Hader uploaded patch set 1 11/05/21, 11:40
-
core-ci voted on patch set 1 V -1 11/05/21, 12:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18947
-
Oliver Hader uploaded patch set 2 11/10/21, 09:07
-
Oliver Hader commented on patch set 2 11/10/21, 09:13
@Richard: It would be great if you could have a look/review here as well. Thx in advance! -
core-ci voted on patch set 2 V +1 11/10/21, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19108
-
Oli Bartsch voted on patch set 2 V +1 CR +1 11/10/21, 10:15
-
Benni Mack commented on patch set 2 V +2 CR +2 11/11/21, 08:39
I do not like the "JavaScriptInterface" name, but I guess that's a matter of taste. -
Benni Mack merged patch set 3 11/11/21, 08:39