Review main Merged

72061[TASK] Explicitly use JavaScript module instructions in dashboard

Oliver Hader CR +2 V +2 Normal +81 −13 updated 11/11/21, 08:39

Commit message

Introduces new `\TYPO3\CMS\Dashboard\Widgets\JavaScriptInterface`,
based on explicit `\TYPO3\CMS\Core\Page\JavaScriptModuleInstruction`
model - to reduce (and avoid) inline JavaScript in the TYPO3 backend.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 68

  1. Oliver Hader uploaded patch set 1 11/05/21, 11:40

  2. core-ci voted on patch set 1 V -1 11/05/21, 12:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18947

  3. Oliver Hader uploaded patch set 2 11/10/21, 09:07

  4. Oliver Hader commented on patch set 2 11/10/21, 09:13

    @Richard: It would be great if you could have a look/review here as well. Thx in advance!
  5. core-ci voted on patch set 2 V +1 11/10/21, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19108

  6. Oli Bartsch voted on patch set 2 V +1 CR +1 11/10/21, 10:15

  7. Benni Mack commented on patch set 2 V +2 CR +2 11/11/21, 08:39

    I do not like the "JavaScriptInterface" name, but I guess that's a matter of taste.
  8. Benni Mack merged patch set 3 11/11/21, 08:39