72063[BUGFIX] Streamline arguments for logicalAnd() query in Extbase
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1115
-
Alexander Schnitzler uploaded patch set 1 11/05/21, 14:50
-
Alexander Schnitzler wrote 11/05/21, 14:51
Topic set to extbase -
Alexander Schnitzler uploaded patch set 2 11/05/21, 14:59
-
core-ci voted on patch set 1 V +1 11/05/21, 15:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18952
-
core-ci voted on patch set 2 V +1 11/05/21, 15:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18955
-
Alexander Schnitzler uploaded patch set 3 11/06/21, 07:33
-
Alexander Schnitzler updated the commit message in patch set 4 11/06/21, 07:35
-
core-ci voted on patch set 3 V +1 11/06/21, 07:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18975
-
core-ci voted on patch set 4 V +1 11/06/21, 07:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18976
-
Oliver Klee commented on patch set 4 11/06/21, 10:54
Query.php:404Do we need $constraint2 here, or could we directly use $furtherConstraints? -
Alexander Schnitzler commented on patch set 4 11/06/21, 11:52
Query.php:404ReplyYes, we do, because now, if only one constraint is mandatory, we cannot return a LogicalAndInterface but return the given Constraint which is wrong. A logical and needs at least two constraints in the future but allows for n more. The optionality of constraint2 will be removed in version 12. -
Oliver Klee commented on patch set 4 11/06/21, 15:11
Thanks for the explanation!Query.php:404ReplyAck -
Benni Mack voted on patch set 4 V +1 CR +1 11/09/21, 07:41
-
Christian Kuhn voted on patch set 4 V +2 CR +2 11/09/21, 16:09
-
Christian Kuhn merged patch set 5 11/09/21, 16:09