72070[TASK] Use icon identifier in module configurations
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 20
- typo3/sysext/backend/Tests/Functional/Backend/Shortcut/ShortcutRepositoryTest.php+2 −2
- typo3/sysext/backend/ext_tables.php+4 −4
- typo3/sysext/belog/ext_tables.php+1 −1
- typo3/sysext/beuser/ext_tables.php+2 −2
- typo3/sysext/dashboard/ext_tables.php+1 −1
- typo3/sysext/extensionmanager/ext_tables.php+1 −1
- typo3/sysext/filelist/ext_tables.php+1 −1
- typo3/sysext/form/ext_tables.php+1 −1
- typo3/sysext/indexed_search/ext_tables.php+1 −1
- typo3/sysext/info/ext_tables.php+1 −1
- typo3/sysext/lowlevel/ext_tables.php+2 −2
- typo3/sysext/recordlist/ext_tables.php+1 −1
- typo3/sysext/recycler/ext_tables.php+1 −1
- typo3/sysext/redirects/ext_tables.php+1 −1
- typo3/sysext/reports/ext_tables.php+1 −1
- typo3/sysext/scheduler/ext_tables.php+1 −1
- typo3/sysext/setup/ext_tables.php+1 −1
- typo3/sysext/tstemplate/ext_tables.php+1 −1
- typo3/sysext/viewpage/ext_tables.php+1 −1
- typo3/sysext/workspaces/ext_tables.php+1 −1
Review log 812
-
Chris Müller uploaded patch set 1 11/05/21, 16:50
-
core-ci voted on patch set 1 V -1 11/05/21, 17:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18965
-
Benni Mack commented on patch set 1 11/05/21, 19:54
removing the files now is IMHO a bad idea (although I'd love to do this). Why? It might be that extensions authors use these icons for their modules (at least, I've seen such things). so only change ext_tables.php and create a second patch to remove the files for v12.0. This wouldn't still be a breaking change, but still... unfortunate after an LTS release I'd say. -
Chris Müller uploaded patch set 2 11/06/21, 12:24
-
Chris Müller commented on patch set 2 11/06/21, 12:25
Reply
Yes, thought also about it. Removed the removals and will add another patch for v12 once this patch is merged. -
core-ci voted on patch set 2 V -1 11/06/21, 12:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18980
-
Chris Müller uploaded patch set 3 11/06/21, 17:55
-
core-ci voted on patch set 3 V -1 11/06/21, 18:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18982
-
core-ci voted on patch set 3 V +1 11/08/21, 18:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18982
-
Oli Bartsch voted on patch set 3 V +1 CR +1 11/08/21, 18:21
-
Benni Mack voted on patch set 3 V +2 CR +2 11/08/21, 18:36
-
Benni Mack merged patch set 4 11/08/21, 18:36