Review main Merged

72070[TASK] Use icon identifier in module configurations

Chris Müller CR +2 V +2 Normal +26 −26 updated 11/08/21, 18:36

Commit message

In most module configurations icons with a distinct path are
used. This is not necessary, as the module icons are already
available from the TYPO3.Icons package and therefore the
icon identifier can be used. For EXT:core this was already done.

The previously referenced icons are not used anymore and will
be removed by a separated patch for v12 once v11 is branched.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 20

Review log 812

  1. Chris Müller uploaded patch set 1 11/05/21, 16:50

  2. core-ci voted on patch set 1 V -1 11/05/21, 17:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18965

  3. Benni Mack commented on patch set 1 11/05/21, 19:54

    removing the files now is IMHO a bad idea (although I'd love to do this). Why? It might be that extensions authors use these icons for their modules (at least, I've seen such things). so only change ext_tables.php and create a second patch to remove the files for v12.0. This wouldn't still be a breaking change, but still... unfortunate after an LTS release I'd say.
  4. Chris Müller uploaded patch set 2 11/06/21, 12:24

  5. Chris Müller commented on patch set 2 11/06/21, 12:25

    Reply

    Yes, thought also about it. Removed the removals and will add another patch for v12 once this patch is merged.
  6. core-ci voted on patch set 2 V -1 11/06/21, 12:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18980

  7. Chris Müller uploaded patch set 3 11/06/21, 17:55

  8. core-ci voted on patch set 3 V -1 11/06/21, 18:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18982

  9. core-ci voted on patch set 3 V +1 11/08/21, 18:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18982

  10. Oli Bartsch voted on patch set 3 V +1 CR +1 11/08/21, 18:21

  11. Benni Mack voted on patch set 3 V +2 CR +2 11/08/21, 18:36

  12. Benni Mack merged patch set 4 11/08/21, 18:36