72071[TASK] Move Composer package artifact to vendor folder
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Hader +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/core/Classes/Composer/PackageArtifactBuilder.php+2 −2
- typo3/sysext/core/Classes/Core/Bootstrap.php+7 −1
- typo3/sysext/core/Classes/Core/SystemEnvironmentBuilder.php+1 −1
- typo3/sysext/core/Classes/Package/Cache/ComposerPackageArtifact.php+3 −3
- typo3/sysext/core/Documentation/Changelog/11.4/Important-95647-ComposerInstallationsAndExtensionUsage.rst+9 −2
Review log 2839
Show 814 earlier messages
-
Simon Gilli uploaded patch set 1 11/05/21, 19:57
-
core-ci voted on patch set 1 V -1 11/05/21, 20:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18968
-
Simon Gilli updated the commit message in patch set 2 11/05/21, 20:18
-
Simon Gilli uploaded patch set 3 11/05/21, 20:27
-
core-ci voted on patch set 2 V -1 11/05/21, 20:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18970
-
core-ci voted on patch set 3 V -1 11/05/21, 20:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18971
-
Simon Gilli uploaded patch set 4 11/05/21, 21:21
-
core-ci voted on patch set 4 V +1 11/05/21, 21:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18972
-
Simon Gilli uploaded patch set 5 11/06/21, 10:57
-
core-ci voted on patch set 5 V +1 11/06/21, 11:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18978
-
Simon Gilli commented on patch set 5 11/07/21, 10:48
This change is ready for review.The TF needs also be changed see https://github.com/TYPO3/testing-framework/pull/300 -
Simon Gilli updated the commit message in patch set 6 11/07/21, 11:05
-
core-ci voted on patch set 6 V +1 11/07/21, 11:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18988
-
Georg Ringer commented on patch set 6 V -1 11/08/21, 06:17
we need a breaking rst or keep the old path as fallback + adopt the other rsts where the path is mentioned!
-
Helmut Hummel commented on patch set 6 11/08/21, 10:26
Reply
Can you please explain the scenario where this change breaks anything? I tried to think about one, but could not imagine anything. -
Helmut Hummel uploaded patch set 7 11/08/21, 12:10
-
Helmut Hummel commented on patch set 7 11/08/21, 12:12
Reply
I changed the doc now, thanks. Other than that, I'm not aware of any action that needs to be done here, but feel free to help us out with a breaking scenario, that should be mitigated. -
Helmut Hummel uploaded patch set 8 11/08/21, 12:21
-
Georg Ringer voted on patch set 8 V +1 CR +1 11/08/21, 12:26
-
core-ci voted on patch set 7 V +1 11/08/21, 12:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19014
-
Helmut Hummel updated the commit message in patch set 9 11/08/21, 12:33
-
Helmut Hummel voted on patch set 9 V +1 CR +1 11/08/21, 12:33
-
Helmut Hummel commented on patch set 9 CR -2 11/08/21, 12:34
Changes in testing framework need to be merged before this one is merged -
core-ci voted on patch set 8 V +1 11/08/21, 12:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19015
-
core-ci voted on patch set 9 V +1 11/08/21, 12:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19017
-
Simon Gilli commented on patch set 9 11/08/21, 16:01
Reply
We did a long brain storming last Saturday on possible breaking scenarios but did not find anything as already mentioned by Helmut before. The issue was raised by the guys from platform.sh and even their current deployment process does not break after this change. Parts can get removed after this change but it will still work fine without any change. -
Georg Ringer commented on patch set 9 11/09/21, 10:56
Reply
yeah thats why I revoted and give a +1, all fine from my side with the latest changes -
Helmut Hummel uploaded patch set 10 11/12/21, 15:56
-
core-ci voted on patch set 10 V -1 11/12/21, 16:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19212
-
Helmut Hummel uploaded patch set 11 11/15/21, 14:53
-
core-ci voted on patch set 11 V +1 11/15/21, 15:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19306
-
Helmut Hummel commented on patch set 11 CR 0 11/15/21, 17:35
https://github.com/TYPO3/testing-framework/pull/300/ is ready and can be merged. So removing my block here -
Oliver Hader voted on patch set 11 V +1 11/15/21, 17:57
-
Oliver Hader commented on patch set 11 11/15/21, 17:58
Works... however I'm not sure whether I understood all possible implications, yet.. -
Benni Mack voted on patch set 11 V +1 CR +1 11/15/21, 19:28
-
Christian Kuhn voted on patch set 11 CR +1 11/15/21, 19:29
-
Benni Mack voted on patch set 11 V +2 CR +2 11/15/21, 19:29
-
Benni Mack merged patch set 12 11/15/21, 19:29
-
Helmut Hummel commented on patch set 12 11/15/21, 22:39
Thanks for the merge!