Review main Merged

72071[TASK] Move Composer package artifact to vendor folder

Simon Gilli CR +2 V +2 Easy +22 −9 updated 11/15/21, 22:39

Commit message

Storing the package artifact in the var/build folder raised
questions how this folder shall be treated in general and during
deployment. Since the Package Artifact is built in
a `composer install` process, it should be treated the same as
other build artifacts like all files in the vendor folder.

To make this more clear, the package artifact is now also stored in
the vendor folder.

Accessing the vendor folder during runtime is now possible with
using Composer 2.1 runtime API, which is required anyway already.

The path to the vendor folder is determined indirectly, by using
the path to the typo3/cms-composer-installers package. This means,
this package must not be replaced by another package with a different
name. Since no public replacements for this package exist and
there are no benefits for a private replacement of this package over
having a private fork with the same package name,
this should not be an impediment.

To ease the required related changes in the testing framework,
late static binding is used for calling
SystemEnvironmentBuilder::usesComposerClassLoading

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 2839

Show 814 earlier messages
  1. Simon Gilli uploaded patch set 1 11/05/21, 19:57

  2. core-ci voted on patch set 1 V -1 11/05/21, 20:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18968

  3. Simon Gilli updated the commit message in patch set 2 11/05/21, 20:18

  4. Simon Gilli uploaded patch set 3 11/05/21, 20:27

  5. core-ci voted on patch set 2 V -1 11/05/21, 20:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18970

  6. core-ci voted on patch set 3 V -1 11/05/21, 20:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18971

  7. Simon Gilli uploaded patch set 4 11/05/21, 21:21

  8. core-ci voted on patch set 4 V +1 11/05/21, 21:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18972

  9. Simon Gilli uploaded patch set 5 11/06/21, 10:57

  10. core-ci voted on patch set 5 V +1 11/06/21, 11:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18978

  11. Simon Gilli commented on patch set 5 11/07/21, 10:48

    This change is ready for review.
  12. Simon Gilli updated the commit message in patch set 6 11/07/21, 11:05

  13. core-ci voted on patch set 6 V +1 11/07/21, 11:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18988

  14. Georg Ringer commented on patch set 6 V -1 11/08/21, 06:17

    we need a breaking rst or keep the old path as fallback + adopt the other rsts where the path is mentioned!
  1. Helmut Hummel commented on patch set 6 11/08/21, 10:26

    Reply

    Can you please explain the scenario where this change breaks anything? I tried to think about one, but could not imagine anything.
  2. Helmut Hummel uploaded patch set 7 11/08/21, 12:10

  3. Helmut Hummel commented on patch set 7 11/08/21, 12:12

    Reply

    I changed the doc now, thanks. Other than that, I'm not aware of any action that needs to be done here, but feel free to help us out with a breaking scenario, that should be mitigated.
  4. Helmut Hummel uploaded patch set 8 11/08/21, 12:21

  5. Georg Ringer voted on patch set 8 V +1 CR +1 11/08/21, 12:26

  6. core-ci voted on patch set 7 V +1 11/08/21, 12:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19014

  7. Helmut Hummel updated the commit message in patch set 9 11/08/21, 12:33

  8. Helmut Hummel voted on patch set 9 V +1 CR +1 11/08/21, 12:33

  9. Helmut Hummel commented on patch set 9 CR -2 11/08/21, 12:34

    Changes in testing framework need to be merged before this one is merged
  10. core-ci voted on patch set 8 V +1 11/08/21, 12:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19015

  11. core-ci voted on patch set 9 V +1 11/08/21, 12:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19017

  12. Simon Gilli commented on patch set 9 11/08/21, 16:01

    Reply

    We did a long brain storming last Saturday on possible breaking scenarios but did not find anything as already mentioned by Helmut before. The issue was raised by the guys from platform.sh and even their current deployment process does not break after this change. Parts can get removed after this change but it will still work fine without any change.
  13. Georg Ringer commented on patch set 9 11/09/21, 10:56

    Reply

    yeah thats why I revoted and give a +1, all fine from my side with the latest changes
  14. Helmut Hummel uploaded patch set 10 11/12/21, 15:56

  15. core-ci voted on patch set 10 V -1 11/12/21, 16:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19212

  16. Helmut Hummel uploaded patch set 11 11/15/21, 14:53

  17. core-ci voted on patch set 11 V +1 11/15/21, 15:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19306

  18. Helmut Hummel commented on patch set 11 CR 0 11/15/21, 17:35

    https://github.com/TYPO3/testing-framework/pull/300/ is ready and can be merged. So removing my block here
  19. Oliver Hader voted on patch set 11 V +1 11/15/21, 17:57

  20. Oliver Hader commented on patch set 11 11/15/21, 17:58

    Works... however I'm not sure whether I understood all possible implications, yet..
  21. Benni Mack voted on patch set 11 V +1 CR +1 11/15/21, 19:28

  22. Christian Kuhn voted on patch set 11 CR +1 11/15/21, 19:29

  23. Benni Mack voted on patch set 11 V +2 CR +2 11/15/21, 19:29

  24. Benni Mack merged patch set 12 11/15/21, 19:29

  25. Helmut Hummel commented on patch set 12 11/15/21, 22:39

    Thanks for the merge!