Review main Merged

72072[TASK] Simplify finder initialization in php-cs-fixer.php

Torben Hansen CR +2 V +2 Easy +2 −8 updated 11/08/21, 10:52

Commit message

Use ignoreVCSIgnored for the Symfony finder initialization
in php-cs-fixer.php to automatically ignore all files
from .gitignore.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Sybille Peters +1
    • Mathias Brodala +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Sybille Peters +1
    • Mathias Brodala +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 78

  1. Torben Hansen uploaded patch set 1 11/06/21, 12:12

  2. core-ci voted on patch set 1 V +1 11/06/21, 12:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18979

  3. Sybille Peters commented on patch set 1 CR +1 11/06/21, 14:15

    nice :) Didn't know this existed.
  4. Sybille Peters commented on patch set 1 V +1 11/06/21, 14:32

    Tested like this: remove cache: .php-cs-fixer.cache (1) $ Build/Scripts/runTests.sh -s cgl $ git diff > no output: ok (2) Made a change in one of the ignored files typo3/install.php (which should get nitpicked by cs-fixer) $ Build/Scripts/runTests.sh -s cgl $ git diff > no output: ok (3) Change in one of the not ignored files - which should get detected by php-cs-fixer. $ git diff > with output: ok $ Build/Scripts/runTests.sh -s cgl $ git diff > with no output: ok
  5. Oliver Klee commented on patch set 1 CR +1 11/06/21, 15:11

    Neat! I didn't know that this is possible!
  6. Mathias Brodala commented on patch set 1 V +1 CR +1 11/08/21, 09:26

    Verified by CI which would fail if it didn't work.
  7. Christian Kuhn voted on patch set 1 V +2 CR +2 11/08/21, 10:52

  8. Christian Kuhn merged patch set 2 11/08/21, 10:52