72074[BUGFIX] Avoid InvalidTypoScriptConditionException in RedirectHandler
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Sybille Peters +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 4
- typo3/sysext/redirects/Classes/Http/Middleware/RedirectHandler.php+11 −0
- typo3/sysext/redirects/Tests/Functional/DebugContext/Service/Fixtures/RedirectService_typoScriptSiteLanguageFallbackCondition.xmlnew+34 −0
- typo3/sysext/redirects/Tests/Functional/DebugContext/Service/Fixtures/RedirectsSiteLanguageFallbackCondition.typoscriptnew+19 −0
- typo3/sysext/redirects/Tests/Functional/DebugContext/Service/RedirectServiceTest.phpnew+85 −0
Review log 912
-
Stefan Bürk uploaded patch set 1 11/07/21, 12:55
-
Stefan Bürk commented on patch set 1 CR -1 11/07/21, 12:56
Patchset 1 only introduce the test. Core CI must fail, thus -1 would be OK for this patchset. This should be ensure this bug and fix is covered correctly by the test. -
core-ci voted on patch set 1 V -1 11/07/21, 13:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18989
-
Stefan Bürk commented on patch set 1 11/07/21, 13:09
^^ failed as expected, and with the correct test which should fail. -
Stefan Bürk uploaded patch set 2 11/07/21, 13:17
-
Stefan Bürk uploaded patch set 3 11/07/21, 13:27
-
core-ci voted on patch set 2 V -1 11/07/21, 13:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18993
-
core-ci voted on patch set 3 V +1 11/07/21, 13:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18997
-
Sybille Peters voted on patch set 3 V +1 11/08/21, 22:12
-
Benni Mack voted on patch set 3 V +1 CR +1 11/10/21, 11:59
-
Christian Kuhn voted on patch set 3 V +2 CR +2 11/10/21, 19:23
-
Christian Kuhn merged patch set 4 11/10/21, 19:23