Review main Merged

72076[TASK] Fix return type declaration for slug provider

Sybille Peters CR +2 V +2 Easy +1 −1 updated 11/08/21, 13:49

Commit message

PHPDoc block for method PageSlugCandidateProvider::getCandidatesForPath()
had incorrect return type of string[].

This is changed to array<int,array<string,mixed>>.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Sybille Peters uploaded patch set 1 11/08/21, 08:23

  2. core-ci voted on patch set 1 V +1 11/08/21, 08:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19004

  3. Sybille Peters commented on patch set 1 11/08/21, 08:48

    Test with bin/phpstan analyze -l3 --no-progress --no-interaction --memory-limit 4G typo3/sysext/core/Classes/Routing/PageSlugCandidateProvider.php
  4. Christian Kuhn voted on patch set 1 V +1 CR +1 11/08/21, 11:31

  5. Oliver Klee voted on patch set 1 CR +1 11/08/21, 12:27

  6. Oli Bartsch voted on patch set 1 V +2 CR +2 11/08/21, 13:49

  7. Oli Bartsch merged patch set 2 11/08/21, 13:49