Review main Merged

72077[BUGFIX] Stabilize recycler AC test

Jochen Roth CR +2 V +2 Easy +2 −1 updated 11/08/21, 11:29

Commit message

Currently the acceptance test for the
recycler module uses "see" to check
if a text appears in the flashmessage
which can cause timing issues.

This has been fixed by using waitForText
to actually wait until the message
appears.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 710

  1. Jochen Roth uploaded patch set 1 11/08/21, 10:08

  2. Oliver Klee voted on patch set 1 CR +1 11/08/21, 10:26

  3. core-ci voted on patch set 1 V +1 11/08/21, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19006

  4. Christian Kuhn updated the commit message in patch set 2 11/08/21, 10:59

  5. Christian Kuhn updated the commit message in patch set 3 11/08/21, 11:00

  6. Christian Kuhn voted on patch set 3 V +1 CR +1 11/08/21, 11:00

  7. core-ci voted on patch set 2 V +1 11/08/21, 11:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19009

  8. core-ci voted on patch set 3 V +1 11/08/21, 11:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19010

  9. Oli Bartsch voted on patch set 3 V +2 CR +2 11/08/21, 11:29

  10. Oli Bartsch merged patch set 4 11/08/21, 11:29