Review main Merged

72080[BUGFIX] Use correct selector for progress bar in workspaces

Oli Bartsch CR +2 V +2 Easy +8 −6 updated 11/09/21, 07:40

Commit message

Since #91085, sending a remote request in workspaces,
e.g. sending records to another stage, is visualized by
a progress bar. The configured selector for the progress
bar however differs between the review module and the
preview module and therefore led to a TypeError.

This is now fixed by using the correct selector
depending on the current module.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 56

  1. Oli Bartsch uploaded patch set 1 11/08/21, 13:33

  2. core-ci voted on patch set 1 V +1 11/08/21, 14:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19020

  3. Benni Mack voted on patch set 1 CR +1 11/08/21, 20:39

  4. Benni Mack voted on patch set 1 V +1 11/09/21, 07:19

  5. Georg Ringer voted on patch set 1 V +2 CR +2 11/09/21, 07:40

  6. Georg Ringer merged patch set 2 11/09/21, 07:40