Review main Merged

72083[BUGFIX] Deprecation free \SplSubject in ExtensionXmlParser

Stefan Bürk CR +2 V +2 Easy +3 −3 updated 11/09/21, 00:20

Commit message

Set void return type for @internal class ExtensionXmlParser
to satisfy PHP 8.1 strict return on SPL classes.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Stefan Bürk uploaded patch set 1 11/08/21, 18:02

  2. Benni Mack voted on patch set 1 V +1 CR +1 11/08/21, 18:06

  3. core-ci voted on patch set 1 V +1 11/08/21, 18:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19037

  4. Oliver Klee voted on patch set 1 CR +1 11/08/21, 18:42

  5. Oli Bartsch voted on patch set 1 V +2 CR +2 11/09/21, 00:20

  6. Oli Bartsch merged patch set 2 11/09/21, 00:20