Review main Merged

72084[BUGFIX] Deprecation free SplObjectStorage in ModuleDataStorageCollection

Stefan Bürk CR +2 V +2 Easy +6 −0 updated 11/09/21, 10:17

Commit message

Add PHP 8.1 attribute #[\ReturnTypeWillChange] with todo to set
correct return type as breaking change in v12 to satisfy PHP 8.1
strict return on SPL classes.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Nikita Hovratov +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Nikita Hovratov +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Stefan Bürk uploaded patch set 1 11/08/21, 18:04

  2. core-ci voted on patch set 1 V +1 11/08/21, 18:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19038

  3. Oliver Klee voted on patch set 1 CR +1 11/08/21, 18:42

  4. Benni Mack voted on patch set 1 V +1 CR +1 11/09/21, 07:19

  5. Nikita Hovratov voted on patch set 1 V +1 CR +1 11/09/21, 09:58

  6. Oli Bartsch voted on patch set 1 V +2 CR +2 11/09/21, 10:17

  7. Oli Bartsch merged patch set 2 11/09/21, 10:17