Review main Merged

72085[BUGFIX] Avoid call mb_strlen(null) in GeneralUtility::fixed_lgd_cs

Stefan Bürk CR +2 V +2 Easy +4 −2 updated 11/09/21, 15:55

Commit message

GeneralUtility::fixed_lgd_cs() may be called with null instead of a
string as first argument, which is passed to mb_strlen(). Feeding
null to mb_strlen() emits a E_DEPRECATED PHP 8.1 error.

This patch sanitizes the call in BackendUtillity and further ensures
that the first parameter $string is a string (until strict type hints
can be added).

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Sybille Peters +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 79

  1. Stefan Bürk uploaded patch set 1 11/08/21, 19:13

  2. core-ci voted on patch set 1 V +1 11/08/21, 19:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19043

  3. Oliver Klee updated the commit message in patch set 2 11/08/21, 20:08

  4. core-ci voted on patch set 2 V +1 11/08/21, 20:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19049

  5. Sybille Peters voted on patch set 2 CR +1 11/08/21, 21:56

  6. Christian Kuhn voted on patch set 2 V +1 CR +1 11/09/21, 13:03

  7. Oli Bartsch voted on patch set 2 V +1 CR +1 11/09/21, 13:59

  8. Christian Kuhn voted on patch set 2 V +2 CR +2 11/09/21, 15:55

  9. Christian Kuhn merged patch set 3 11/09/21, 15:55