Review main Merged

72086[BUGFIX] Avoid calling nl2br(null) in Nl2brViewHelper

Stefan Bürk CR +2 V +2 Easy +1 −1 updated 11/09/21, 00:10

Commit message

Nl2brViewHelper::renderStatic() calls nl2br with the return
of the called $renderChildrenClosure which may return null.
Feeding null to nl2br() emits a E_DEPRECATED PHP 8.1 error.
Sanatize the call.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Stefan Bürk uploaded patch set 1 11/08/21, 19:27

  2. Georg Ringer voted on patch set 1 V +1 CR +1 11/08/21, 19:28

  3. core-ci voted on patch set 1 V +1 11/08/21, 19:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19044

  4. Oliver Klee voted on patch set 1 CR +1 11/08/21, 20:08

  5. Oli Bartsch voted on patch set 1 V +2 CR +2 11/09/21, 00:10

  6. Oli Bartsch merged patch set 2 11/09/21, 00:10