7209[TASK] Improve username information in top toolbar
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Markus Klein +1
-
Verified V +2
- Christian Kuhn +2
- Markus Klein +1
Issues 1
Files 2
Review log 14
-
Markus Klein commented on patch set 1 01/28/12, 12:42
(1 inline comment)A better title please. If you only read the title, you have no clue what this is about. -
Georg Ringer commented on patch set 1 01/28/12, 12:42
Do not submit as written in the ticket, I really would like to have a info from hci team when something like that is changed. furthermore if SU is used, I want to have the username still visible as this is not my regular user/-name -
Markus Klein uploaded patch set 3 01/28/12, 12:42
-
Markus Klein commented on patch set 3 01/28/12, 12:42
Verified; Looks good to me, but someone else must approve Improved commit message. Added another htmlspecialchars(). -
Christian Kuhn commented on patch set 3 V 0 01/28/12, 12:42
by team member; Looks good to me, approved Merged. The other ideas in the HCI ticket can be done with further patches, so it is perfectly ok to merge this one now. -
Philipp Gampe commented on patch set 2 01/28/12, 12:42
Verified; Looks good to me, but someone else must approve Works -
Felix Kopp uploaded patch set 2 01/28/12, 12:42
-
Felix Kopp commented on patch set 3 01/28/12, 12:42
Anything new about this? -
Felix Kopp commented on patch set 3 01/28/12, 12:42
@Georg, please review the current state - got votes in the forge ticket and in SU-case the username is displayed. Cheers & happy holidays! -
Felix Kopp commented on patch set 3 01/28/12, 12:42
Anything new? Just a friendly reminder :) -
Mr. Jenkins commented on patch set 1 01/28/12, 12:42
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2732/ : SUCCESS -
Mr. Jenkins commented on patch set 2 01/28/12, 12:42
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2855/ : SUCCESS -
Mr. Jenkins commented on patch set 3 01/28/12, 12:42
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2858/ : SUCCESS -
Christian Kuhn merged patch set 3 01/28/12, 12:42