Review main Merged

7209[TASK] Improve username information in top toolbar

Felix Kopp CR +2 V +2 Easy +18 −17 updated 06/03/13, 20:49

Commit message

Hides the username text if a full name is available.
If the superuser mode is enabled the username is preserved.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Markus Klein +1
  • Verified V +2
    • Christian Kuhn +2
    • Markus Klein +1

Issues 1

Files 2

Review log 14

  1. Markus Klein commented on patch set 1 01/28/12, 12:42

    (1 inline comment)
    A better title please. If you only read the title, you have no clue what this is about.
  2. Georg Ringer commented on patch set 1 01/28/12, 12:42

    Do not submit as written in the ticket, I really would like to have a info from hci team when something like that is changed. furthermore if SU is used, I want to have the username still visible as this is not my regular user/-name
  3. Markus Klein uploaded patch set 3 01/28/12, 12:42

  4. Markus Klein commented on patch set 3 01/28/12, 12:42

    Verified; Looks good to me, but someone else must approve Improved commit message. Added another htmlspecialchars().
  5. Christian Kuhn commented on patch set 3 V 0 01/28/12, 12:42

    by team member; Looks good to me, approved Merged. The other ideas in the HCI ticket can be done with further patches, so it is perfectly ok to merge this one now.
  6. Philipp Gampe commented on patch set 2 01/28/12, 12:42

    Verified; Looks good to me, but someone else must approve Works
  7. Felix Kopp uploaded patch set 2 01/28/12, 12:42

  8. Felix Kopp commented on patch set 3 01/28/12, 12:42

    Anything new about this?
  9. Felix Kopp commented on patch set 3 01/28/12, 12:42

    @Georg, please review the current state - got votes in the forge ticket and in SU-case the username is displayed. Cheers & happy holidays!
  10. Felix Kopp commented on patch set 3 01/28/12, 12:42

    Anything new? Just a friendly reminder :)
  11. Mr. Jenkins commented on patch set 1 01/28/12, 12:42

  12. Mr. Jenkins commented on patch set 2 01/28/12, 12:42

  13. Mr. Jenkins commented on patch set 3 01/28/12, 12:42

  14. Christian Kuhn merged patch set 3 01/28/12, 12:42