Review main Merged

72092[BUGFIX] Fix warning in InputLinkElement

Nikita Hovratov CR +2 V +2 Easy +1 −1 updated 11/09/21, 15:56

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 910

  1. Nikita Hovratov uploaded patch set 1 11/09/21, 08:48

  2. core-ci voted on patch set 1 V +1 11/09/21, 09:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19059

  3. Georg Ringer voted on patch set 1 V +1 CR +1 11/09/21, 10:56

  4. Benni Mack commented on patch set 1 11/09/21, 11:25

    InputLinkElement.php:417

    what happens if $table is empty then? it gets put into BackendUtility::getRecord() shouldn't we catch that?
  5. Nikita Hovratov commented on patch set 1 11/09/21, 11:49

    InputLinkElement.php:417 Reply

    It will return null for $record. There is an !empty check for $table. Of course we can catch it earlier. Don't know if this is necessary.
  6. Christian Kuhn commented on patch set 1 V +2 CR +2 11/09/21, 13:46

    looks ok to me. guess we can do it like that.
  7. Christian Kuhn voted on patch set 1 V +1 CR +1 11/09/21, 13:46

  8. Christian Kuhn voted on patch set 1 V +2 CR +2 11/09/21, 15:55

  9. Christian Kuhn merged patch set 2 11/09/21, 15:56

  10. Christian Kuhn commented on patch set 2 11/09/21, 15:56

    InputLinkElement.php:417 Reply

    Done