Review main Merged

72093[BUGFIX] Restore new pages behavior in context menu

Oli Bartsch CR +2 V +2 Easy +8 −3 updated 11/09/21, 16:06

Commit message

In prior versions, creating a new page via the context
menu inserted the new page "inside". This however
changed to "after" in v8, leading to misbehavior,
especially for non-admins, as they are usually not
allowed to create pages on pid=0.

This is now fixed by restoring the previous behavior
of inserting pages "inside" instead of "after".

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Markus Klein +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Markus Klein +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1012

  1. Oli Bartsch uploaded patch set 1 11/09/21, 10:15

  2. Markus Klein commented on patch set 1 11/09/21, 10:19

    lovely... can we make that happen for v10 too please?
  3. Markus Klein commented on patch set 1 11/09/21, 10:19

    Suggestion, lets adjust the label as well to "New page inside".
  4. core-ci voted on patch set 1 V +1 11/09/21, 10:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19061

  5. Oli Bartsch uploaded patch set 2 11/09/21, 11:18

  6. Oli Bartsch commented on patch set 2 11/09/21, 11:19

    Reply

    Done

    Reply

    Done
  7. Jochen Roth voted on patch set 2 V +1 CR +1 11/09/21, 11:29

  8. core-ci voted on patch set 2 V +1 11/09/21, 11:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19062

  9. Markus Klein voted on patch set 2 V +1 CR +1 11/09/21, 12:47

  10. Christian Kuhn voted on patch set 2 V +1 CR +1 11/09/21, 16:04

  11. Oli Bartsch voted on patch set 2 V +2 CR +2 11/09/21, 16:06

  12. Oli Bartsch merged patch set 3 11/09/21, 16:06