Review main Merged

72102[BUGFIX] Handle localizeReferencesAtParentLocalization for group/db

Christian Kuhn CR +2 V +2 Hard +276 −12 updated 11/10/21, 22:40

Commit message

TCA config property 'localizeReferencesAtParentLocalization'
for database relations is only handled with type=select
having a 'foreign_table' defined.

With the similar type=group, this is only handled if
'foreign_table' is set, which is odd since group is based
on 'allowed' over 'foreign_table'.

The change adapts DataHandler to consider 'allowed' with
type=group tables and checks whether at least one of them
is localizable.

This solves an @todo from #94570 in the group DataHandling
tests. The test set is completed by adding a similar set
for type=select.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 13

Review log 1317

  1. Christian Kuhn uploaded patch set 1 11/09/21, 18:49

  2. Christian Kuhn commented on patch set 1 CR -1 11/09/21, 18:51

    Repushed from https://review.typo3.org/c/Packages/TYPO3.CMS/+/15399 since that patch is somehow broken in gerrit. WIP for now, waits for https://review.typo3.org/c/Packages/TYPO3.CMS/+/69904 to be merged.
  3. core-ci voted on patch set 1 V +1 11/09/21, 19:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19082

  4. Christian Kuhn uploaded patch set 2 11/10/21, 18:37

  5. core-ci voted on patch set 2 V +1 11/10/21, 18:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19141

  6. Christian Kuhn voted on patch set 2 CR -1 11/10/21, 18:58

  7. Christian Kuhn uploaded patch set 3 11/10/21, 21:59

  8. Christian Kuhn updated the commit message in patch set 4 11/10/21, 22:10

  9. Christian Kuhn voted on patch set 4 V +1 CR +1 11/10/21, 22:11

  10. Christian Kuhn uploaded patch set 5 11/10/21, 22:12

  11. Christian Kuhn updated the commit message in patch set 6 11/10/21, 22:14

  12. core-ci voted on patch set 3 V +1 11/10/21, 22:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19156

  13. Christian Kuhn updated the commit message in patch set 7 11/10/21, 22:17

  14. core-ci voted on patch set 7 V +1 11/10/21, 22:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19161

  15. Christian Kuhn voted on patch set 7 V +1 CR +1 11/10/21, 22:34

  16. Benni Mack voted on patch set 7 V +2 CR +2 11/10/21, 22:40

  17. Benni Mack merged patch set 8 11/10/21, 22:40