Review main Merged

72103[BUGFIX] Fix various undefined array key errors in PHP8

Chris Müller CR +2 V +2 Easy +5 −3 updated 11/10/21, 12:27

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1113

  1. Chris Müller uploaded patch set 1 11/09/21, 18:53

  2. Christian Kuhn voted on patch set 1 CR +1 11/09/21, 18:56

  3. core-ci voted on patch set 1 V +1 11/09/21, 19:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19083

  4. Christian Kuhn voted on patch set 1 V +1 11/09/21, 19:19

  5. Nikita Hovratov commented on patch set 1 11/09/21, 21:20

    ExtensionManagementUtility.php:761

    Can we use ??= here ? $GLOBALS['PAGES_TYPES']['default']['allowedTables'] ??= '';
  6. Christian Kuhn commented on patch set 1 11/09/21, 22:07

    ExtensionManagementUtility.php:761 Reply

    cosmetically correct. please push.
  7. Nikita Hovratov uploaded patch set 2 11/10/21, 08:58

  8. Nikita Hovratov commented on patch set 2 11/10/21, 08:58

    ExtensionManagementUtility.php:761 Reply

    Done
  9. core-ci voted on patch set 2 V +1 11/10/21, 09:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19107

  10. Christian Kuhn voted on patch set 2 V +1 CR +1 11/10/21, 10:13

  11. Nikita Hovratov voted on patch set 2 V +1 CR +1 11/10/21, 11:24

  12. Christian Kuhn voted on patch set 2 V +2 CR +2 11/10/21, 12:27

  13. Christian Kuhn merged patch set 3 11/10/21, 12:27