Review main Merged

72110[BUGFIX] Avoid calling htmlspecialchars(null) in GeneralUtility

Stefan Bürk CR +2 V +2 Easy +1 −1 updated 11/10/21, 09:55

Commit message

GeneralUtility::implodeAttributes() calls htmlspecialchars() on the
array values to sanitize them. The values may be null instead of a
string, thus feeding null to htmlspecialchars() emits a E_DEPRECATED
PHP 8.1 error. Sanitize call.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Stefan Bürk uploaded patch set 1 11/10/21, 07:08

  2. core-ci voted on patch set 1 V +1 11/10/21, 07:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19097

  3. Christian Kuhn updated the commit message in patch set 2 11/10/21, 09:27

  4. Christian Kuhn voted on patch set 2 V +1 CR +1 11/10/21, 09:28

  5. Wouter Wolters voted on patch set 2 V +1 CR +1 11/10/21, 09:48

  6. core-ci voted on patch set 2 V +1 11/10/21, 09:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19118

  7. Nikita Hovratov voted on patch set 2 CR +1 11/10/21, 09:53

  8. Christian Kuhn voted on patch set 2 V +2 CR +2 11/10/21, 09:55

  9. Christian Kuhn merged patch set 3 11/10/21, 09:55