Review 10.4 Abandoned

72121[BUGFIX] Avoid fatal error in image rendering when processing fails

Helmut Hummel CR 0 V 0 Easy +9 −9 updated 02/05/22, 11:16

Commit message

Fatal error can occur, when the file variable isn't a string,
which only happens, when file processing failed or the resolved
file isn't an image.

Nevertheless the fatal error should be avoided.

Also clean up some variable usage to not change the type
of variable and remove some not needed isset() check
for better readability.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 710

  1. Helmut Hummel commented on patch set 1 11/17/21, 10:19

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php
  2. core-ci voted on patch set 1 V -1 11/17/21, 10:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19395

  3. Helmut Hummel commented on patch set 2 11/17/21, 10:23

    Published edit on patch set 1.
  4. Helmut Hummel commented on patch set 3 11/17/21, 10:24

    Published edit on patch set 2.
  5. Helmut Hummel marked it ready for review 11/17/21, 10:26

  6. core-ci voted on patch set 2 V +1 11/17/21, 10:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19396

  7. core-ci voted on patch set 3 V +1 11/17/21, 10:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19397

  8. Oliver Klee voted on patch set 3 CR +1 11/17/21, 12:37

  9. Christian Kuhn commented on patch set 3 02/05/22, 11:16

    hey. i'm going to abandon this v10 backport: it does not seem to be critical and forgotten and is pending for 3 month now. if this is still important for v10, the patch can be resurrected.
  10. Christian Kuhn abandoned the change 02/05/22, 11:16