Review main Merged

72136[BUGFIX] Fix saving command line scheduler tasks in PHP 8

Alexander Stehlik CR +2 V +2 Easy +1 −1 updated 11/10/21, 10:10

Commit message

Prevent undefined array key access in saveAdditionalFields()
method in ExecuteSchedulableCommandAdditionalFieldProvider.

When the command line task is initially saved the arguments
array is not submitted.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Alexander Stehlik uploaded patch set 1 11/10/21, 09:09

  2. core-ci voted on patch set 1 V +1 11/10/21, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19109

  3. Wouter Wolters voted on patch set 1 V +1 CR +1 11/10/21, 09:49

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 11/10/21, 10:10

  5. Christian Kuhn merged patch set 2 11/10/21, 10:10